doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-3821: QueryBuilder throws QueryException when Expr\Comparison($x, 'LIKE', $y) with 'LIKE' operator was added in where clause #4680

New Issue
Open
opened 2026-01-22 14:47:23 +01:00 by admin · 0 comments
admin commented 2026-01-22 14:47:23 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Jul 13, 2015).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user eghlima.r@gmail.com:

This is the query from QueryBuilder->getDQL():

SELECT c FROM wsi\ams\model\Cell c INNER JOIN c.accountingUnit au WHERE 'name' LIKE ?1

We are using YII (1.1.16) and Doctrine ORM (2.5).
For YII grid, we need to handle filtering. We accept user input and try to add them all to an Expr\orX clause then add this expression to our QueryBuilder object at the end.
The problem as i could understood is expr\like internally handle by expr\comparison. this comparison later will use in Parser class and in ComparisonOperator method, there is no case for LIKE in switch-case at all. but before that method in Parser class there is a method called: Parser::SimpleConditionalExpression and in this method there is:

if ($token['type'] === Lexer::T_LIKE) {
            return $this->LikeExpression();
}

and it should handle like in this clause (If i get it right?), but $token['type'] is holding attribute name(in my case name) not the constant belong to Lexer::T_LIKE and so it ignores this clause and goes down into:

return $this->ComparisonExpression();

Example of code that throws exception:

if(isset($*REQUEST[$rootEntity])){ // accept filter parameter from $*REQUEST
            $or = $this->getQueryBuilder()->expr()->orX();
            foreach($_REQUEST[$rootEntity] as $key => $val){ // for each name => value 
                if($val){ // if it contains valid value
                    $or->add($this->getQueryBuilder()->expr()->like("'" . $key . "'", ":" . $key));
                    $this->getQueryBuilder()->setParameters(array($key => $val));
                }
            }
            $this->getQueryBuilder()->andWhere($or); // finally add that OR clause to query
}

Exception details:

<h1>Doctrine\ORM\Query\QueryException</h1>
<p>[Syntax Error] line 0, col 79: Error: Expected =, <, <=, <>, >, >=, !=, got 'LIKE' (/home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/QueryException.php:52)</p>
<pre>
#0 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(448): Doctrine\ORM\Query\QueryException::syntaxError('line 0, col 79:...', object(Doctrine\ORM\Query\QueryException))
#1 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(3325): Doctrine\ORM\Query\Parser->syntaxError('=, <, <=, <>, >...')
#2 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(3040): Doctrine\ORM\Query\Parser->ComparisonOperator()
#3 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2564): Doctrine\ORM\Query\Parser->ComparisonExpression()
#4 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2447): Doctrine\ORM\Query\Parser->SimpleConditionalExpression()
#5 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2423): Doctrine\ORM\Query\Parser->ConditionalPrimary()
#6 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2391): Doctrine\ORM\Query\Parser->ConditionalFactor()
#7 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2366): Doctrine\ORM\Query\Parser->ConditionalTerm()
#8 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(1333): Doctrine\ORM\Query\Parser->ConditionalExpression()
#9 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(876): Doctrine\ORM\Query\Parser->WhereClause()
#10 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(843): Doctrine\ORM\Query\Parser->SelectStatement()
#11 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(268): Doctrine\ORM\Query\Parser->QueryLanguage()
#12 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(351): Doctrine\ORM\Query\Parser->getAST()
#13 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query.php(281): Doctrine\ORM\Query\Parser->parse()
#14 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query.php(293): Doctrine\ORM\Query->_parse()
#15 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(969): Doctrine\ORM\Query->_doExecute()
#16 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(924): Doctrine\ORM\AbstractQuery->executeIgnoreQueryCache(NULL, 1)
#17 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(727): Doctrine\ORM\AbstractQuery->execute(NULL, 1)
#18 /home/mohammad/workspace/ir.wsi.base/protected/lib/doctrine/DataProvider.php(144): Doctrine\ORM\AbstractQuery->getResult()
#19 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/web/CDataProvider.php(170): lib\doctrine\DataProvider->fetchData()
#20 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/zii/widgets/CBaseListView.php(125): CDataProvider->getData()
#21 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/zii/widgets/grid/CGridView.php(339): CBaseListView->init()
#22 /home/mohammad/workspace/ir.wsi.base/protected/vendor/clevertech/yii-booster/src/widgets/TbGridView.php(68): CGridView->init()
#23 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3502): TbGridView->init()
#24 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3525): CBaseController->createWidget('booster.widgets...', Array)
#25 /home/mohammad/workspace/ir.wsi.base/protected/modules/ams/views/cell/list.php(52): CBaseController->widget('booster.widgets...', Array)
#26 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3493): require('/home/mohammad/...')
#27 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3472): CBaseController->renderInternal('/home/mohammad/...', NULL, true)
#28 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3904): CBaseController->renderFile('/home/mohammad/...', NULL, true)
#29 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3872): CController->renderPartial('list', NULL, true)
#30 /home/mohammad/workspace/ir.wsi.base/protected/modules/ams/controllers/CellController.php(36): CController->render('list')
#31 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(4139): CellController->actionList()
#32 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3652): CInlineAction->runWithParams(Array)
#33 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3637): CController->runAction(Object(CInlineAction))
#34 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3627): CController->runActionWithFilters(Object(CInlineAction), Array)
#35 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1761): CController->run('list')
#36 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1681): CWebApplication->runController('ams/cell/list')
#37 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1202): CWebApplication->processRequest()
#38 /home/mohammad/workspace/ir.wsi.base/index.php(13): CApplication->run()
#39 {main}</pre>
Originally created by @doctrinebot on GitHub (Jul 13, 2015). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user eghlima.r@gmail.com: This is the query from `QueryBuilder->getDQL()`: `SELECT c FROM wsi\ams\model\Cell c INNER JOIN c.accountingUnit au WHERE 'name' LIKE ?1` We are using YII (1.1.16) and Doctrine ORM (2.5). For YII grid, we need to handle filtering. We accept user input and try to add them all to an Expr\orX clause then add this expression to our QueryBuilder object at the end. The problem as i could understood is expr\like internally handle by expr\comparison. this comparison later will use in Parser class and in ComparisonOperator method, there is no case for LIKE in switch-case at all. but before that method in Parser class there is a method called: Parser::SimpleConditionalExpression and in this method there is: ``` if ($token['type'] === Lexer::T_LIKE) { return $this->LikeExpression(); } ``` and it should handle like in this clause (If i get it right?), but $token['type'] is holding attribute name(in my case `name`) not the constant belong to Lexer::T_LIKE and so it ignores this clause and goes down into: ``` return $this->ComparisonExpression(); ``` Example of code that throws exception: ``` if(isset($*REQUEST[$rootEntity])){ // accept filter parameter from $*REQUEST $or = $this->getQueryBuilder()->expr()->orX(); foreach($_REQUEST[$rootEntity] as $key => $val){ // for each name => value if($val){ // if it contains valid value $or->add($this->getQueryBuilder()->expr()->like("'" . $key . "'", ":" . $key)); $this->getQueryBuilder()->setParameters(array($key => $val)); } } $this->getQueryBuilder()->andWhere($or); // finally add that OR clause to query } ``` Exception details: ``` <h1>Doctrine\ORM\Query\QueryException</h1> <p>[Syntax Error] line 0, col 79: Error: Expected =, <, <=, <>, >, >=, !=, got 'LIKE' (/home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/QueryException.php:52)</p> <pre> #0 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(448): Doctrine\ORM\Query\QueryException::syntaxError('line 0, col 79:...', object(Doctrine\ORM\Query\QueryException)) #1 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(3325): Doctrine\ORM\Query\Parser->syntaxError('=, <, <=, <>, >...') #2 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(3040): Doctrine\ORM\Query\Parser->ComparisonOperator() #3 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2564): Doctrine\ORM\Query\Parser->ComparisonExpression() #4 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2447): Doctrine\ORM\Query\Parser->SimpleConditionalExpression() #5 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2423): Doctrine\ORM\Query\Parser->ConditionalPrimary() #6 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2391): Doctrine\ORM\Query\Parser->ConditionalFactor() #7 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(2366): Doctrine\ORM\Query\Parser->ConditionalTerm() #8 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(1333): Doctrine\ORM\Query\Parser->ConditionalExpression() #9 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(876): Doctrine\ORM\Query\Parser->WhereClause() #10 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(843): Doctrine\ORM\Query\Parser->SelectStatement() #11 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(268): Doctrine\ORM\Query\Parser->QueryLanguage() #12 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(351): Doctrine\ORM\Query\Parser->getAST() #13 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query.php(281): Doctrine\ORM\Query\Parser->parse() #14 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/Query.php(293): Doctrine\ORM\Query->_parse() #15 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(969): Doctrine\ORM\Query->_doExecute() #16 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(924): Doctrine\ORM\AbstractQuery->executeIgnoreQueryCache(NULL, 1) #17 /home/mohammad/workspace/ir.wsi.base/protected/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php(727): Doctrine\ORM\AbstractQuery->execute(NULL, 1) #18 /home/mohammad/workspace/ir.wsi.base/protected/lib/doctrine/DataProvider.php(144): Doctrine\ORM\AbstractQuery->getResult() #19 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/web/CDataProvider.php(170): lib\doctrine\DataProvider->fetchData() #20 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/zii/widgets/CBaseListView.php(125): CDataProvider->getData() #21 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/zii/widgets/grid/CGridView.php(339): CBaseListView->init() #22 /home/mohammad/workspace/ir.wsi.base/protected/vendor/clevertech/yii-booster/src/widgets/TbGridView.php(68): CGridView->init() #23 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3502): TbGridView->init() #24 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3525): CBaseController->createWidget('booster.widgets...', Array) #25 /home/mohammad/workspace/ir.wsi.base/protected/modules/ams/views/cell/list.php(52): CBaseController->widget('booster.widgets...', Array) #26 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3493): require('/home/mohammad/...') #27 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3472): CBaseController->renderInternal('/home/mohammad/...', NULL, true) #28 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3904): CBaseController->renderFile('/home/mohammad/...', NULL, true) #29 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3872): CController->renderPartial('list', NULL, true) #30 /home/mohammad/workspace/ir.wsi.base/protected/modules/ams/controllers/CellController.php(36): CController->render('list') #31 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(4139): CellController->actionList() #32 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3652): CInlineAction->runWithParams(Array) #33 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3637): CController->runAction(Object(CInlineAction)) #34 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(3627): CController->runActionWithFilters(Object(CInlineAction), Array) #35 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1761): CController->run('list') #36 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1681): CWebApplication->runController('ams/cell/list') #37 /home/mohammad/workspace/ir.wsi.base/protected/vendor/yiisoft/yii/framework/yiilite.php(1202): CWebApplication->processRequest() #38 /home/mohammad/workspace/ir.wsi.base/index.php(13): CApplication->run() #39 {main}</pre> ```
admin added the Bug label 2026-01-22 14:47:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#4680
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?