mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3658: [GH-1365] fix rare query test failures due to nondeterminism without order by clause #4494
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Apr 3, 2015).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of zeroedin-bill:
Url: https://github.com/doctrine/doctrine2/pull/1365
Message:
I was wondering why this travis testrun failed. I investigated and found that the queries involved did not have order by clauses, but were assuming that the query result would return in the same order in which the records were persisted. This is not guaranteed to be the case on most RDBs.
This PR simply adds an order by clause to the queries that will produce a deterministic result and prevent spurious test failures.
@doctrinebot commented on GitHub (Apr 4, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1365] was assigned:
https://github.com/doctrine/doctrine2/pull/1365
@doctrinebot commented on GitHub (Apr 4, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1365] was closed:
https://github.com/doctrine/doctrine2/pull/1365
@doctrinebot commented on GitHub (Apr 4, 2015):
Issue was closed with resolution "Fixed"