doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-3612: Make SQLFilter#em protected #4440

New Issue
Open
opened 2026-01-22 14:41:42 +01:00 by admin · 2 comments
admin commented 2026-01-22 14:41:42 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Mar 11, 2015).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user nurikabe:

SQLFilter#em is private, which can be troublesome when extending SQLFilter. I notice, for example, that the Gedmo SoftDeleteableFilter goes to the trouble of using reflection to get access to SoftDeleteableFilter#em.

Originally created by @doctrinebot on GitHub (Mar 11, 2015). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user nurikabe: SQLFilter#em is private, which can be troublesome when extending SQLFilter. I notice, for example, that the Gedmo SoftDeleteableFilter goes to the trouble of using reflection to get access to SoftDeleteableFilter#em.
admin added the Improvement label 2026-01-22 14:41:42 +01:00
admin commented 2026-01-22 14:41:42 +01:00
Author
Owner
Copy Link

@Steveb-p commented on GitHub (Jun 12, 2019):

I've found this issue when I was looking for anything related to extending SQLFilter class. Is this still something that would be accepted if a PR would be provided?

From what I've seen from code usage it would be worthwile to add an interface, since it is not strictly required for one to extend SQLFilter for a class to work with SqlWalker (I've tested this in my app and filter was applied successfully just based on the result of addFilterConstraint method - I know that there is also the case of parameters, but I believe SQLFilter should be more "extension-friendly"? Maybe drop final from __construct to allow passing additional dependencies, if there are any required)

@Steveb-p commented on GitHub (Jun 12, 2019): I've found this issue when I was looking for anything related to extending `SQLFilter` class. Is this still something that would be accepted if a PR would be provided? From what I've seen from code usage it would be worthwile to add an interface, since it is not strictly required for one to extend `SQLFilter` for a class to work with `SqlWalker` (I've tested this in my app and filter was applied successfully just based on the result of `addFilterConstraint` method - I know that there is also the case of parameters, but I believe `SQLFilter` should be more "extension-friendly"? Maybe drop `final` from `__construct` to allow passing additional dependencies, if there are any required)
admin commented 2026-01-22 14:41:42 +01:00
Author
Owner
Copy Link

@sebsastianek commented on GitHub (Oct 16, 2019):

+1 for dropping final in constructor of SQLFilter

@sebsastianek commented on GitHub (Oct 16, 2019): +1 for dropping final in constructor of SQLFilter
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Improvement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#4440
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?