mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-3583: [GH-1309] [DDC-3582] Fix hydration of nested embeddables #4405
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Feb 22, 2015).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of jankramer:
Url: https://github.com/doctrine/doctrine2/pull/1309
Message:
The wrong class is chosen when hydrating embeddables that are part of a nested structure. See
DDC3582Testfor a demonstration. The fix is to useclassinstead ofembeddedClassto instantiate the embeddable in ReflectionEmbeddedProperty.The test I removed from ReflectionEmbeddedPropertyTest was failing because you cannot instantiate an abstract class (and rightfully so). However, as this would not be possible in practice anyway (you always end up extending the abstract class), I think this test can be removed safely.
@doctrinebot commented on GitHub (Feb 22, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1309] was closed:
https://github.com/doctrine/doctrine2/pull/1309
@doctrinebot commented on GitHub (Feb 27, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1311] was assigned:
https://github.com/doctrine/doctrine2/pull/1311
@doctrinebot commented on GitHub (Feb 27, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1311] was merged:
https://github.com/doctrine/doctrine2/pull/1311