doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-3549: [GH-1292] Mark getSelectConditionStatementColumnSQL method as private #4367

New Issue
Closed
opened 2026-01-22 14:40:21 +01:00 by admin · 2 comments
admin commented 2026-01-22 14:40:21 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Jan 28, 2015).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of goetas:

Url: https://github.com/doctrine/doctrine2/pull/1292

Message:

The Doctrine/\ORM\Persisters\BasicEntityPersister::getSelectConditionStatementColumnSQL method has been marked as private.

The current protected mark is a bit unuseful since everything is already handled into the public method getSelectConditionStatementSQL.

Originally created by @doctrinebot on GitHub (Jan 28, 2015). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user @doctrinebot: This issue is created automatically through a Github pull request on behalf of goetas: Url: https://github.com/doctrine/doctrine2/pull/1292 Message: The `Doctrine/\ORM\Persisters\BasicEntityPersister::getSelectConditionStatementColumnSQL` method has been marked as `private`. The current `protected` mark is a bit unuseful since everything is already handled into the public method `getSelectConditionStatementSQL`.
admin added the Improvement label 2026-01-22 14:40:21 +01:00
admin closed this issue 2026-01-22 14:40:21 +01:00
admin commented 2026-01-22 14:40:22 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jan 29, 2015):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1292] was merged:
https://github.com/doctrine/doctrine2/pull/1292

@doctrinebot commented on GitHub (Jan 29, 2015): Comment created by @doctrinebot: A related Github Pull-Request [GH-1292] was merged: https://github.com/doctrine/doctrine2/pull/1292
admin commented 2026-01-22 14:40:22 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jan 29, 2015):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Jan 29, 2015): Issue was closed with resolution "Fixed"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Improvement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#4367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?