mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3454: [GH-1224] Updated setParameters function for not replace all parameters #4260
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Dec 17, 2014).
Originally assigned to: @guilhermeblanco on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of uthopiko:
Url: https://github.com/doctrine/doctrine2/pull/1224
Message:
When you create QueryBuilder and you bind some parameters, if you use setParameters function after bind other parameters, previous parameters are removed(https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L558). This would not be a problem if it was the same behaviour with the attribute $_parameterMappings (in ParserResult), but it's not the case, given that it keeps the number of parameters introduced, throwing an exception(https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query.php#L293). To prevent this, I've made it initialize the setParameters with the existing ones.
@doctrinebot commented on GitHub (Dec 17, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1224] was assigned:
https://github.com/doctrine/doctrine2/pull/1224
@doctrinebot commented on GitHub (Jan 13, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1224] was closed:
https://github.com/doctrine/doctrine2/pull/1224
@doctrinebot commented on GitHub (Jan 13, 2015):
Issue was closed with resolution "Won't Fix"