mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3437: [GH-1213] fix instantiation of embedded object in ReflectionEmbeddedProperty #4237
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Dec 6, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of austinsmorris:
Url: https://github.com/doctrine/doctrine2/pull/1213
Message:
Recently, ReflectionEmbeddedProperty was updated to extend ReflectionProperty. This broke any embeddable that extends an abstract class. That's because if a property is defined in the abstract class,
$this->classis alway the abstract class and thus cannot be instantiated. The$classparameter that is passed into the constructor needs to be stored, and that class should be instantiated, not the the property's declaring class.@doctrinebot commented on GitHub (Dec 6, 2014):
@doctrinebot commented on GitHub (Dec 7, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1213] was assigned:
https://github.com/doctrine/doctrine2/pull/1213
@doctrinebot commented on GitHub (Dec 8, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1213] was closed:
https://github.com/doctrine/doctrine2/pull/1213
@doctrinebot commented on GitHub (Dec 8, 2014):
Issue was closed with resolution "Fixed"