mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3355: [GH-1164] [QueryBuilder] Remove unused method parameters to run on HHVM/PHP7 #4146
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Oct 17, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of AlphaStream:
Url: https://github.com/doctrine/doctrine2/pull/1164
Message:
PHP5 treats the left part of an assignment to a method parameter as an independent local variable, while HHVM/PHP7 treats it as a reference to the method parameter. This leads to the value of the parameter being changed, which, in turn, causes func_get_args() to return not what is expected.
This commit is a part of the effort to make Symfony run flawlessly on HHVM. This issue causes a bunch of Symfony tests to fail on HHVM.
The master is currently broken, so the best thing I could do was to make sure the number of test failures remained the same after the change.
If possible, please merge this to version 2.2 used by Symfony 2.4.
@doctrinebot commented on GitHub (Oct 19, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1164] was closed:
https://github.com/doctrine/doctrine2/pull/1164
@doctrinebot commented on GitHub (Oct 19, 2014):
Issue was closed with resolution "Fixed"