DDC-30: DateTimeType should take into account null as a possible value #41

New Issue

admin · 2026-01-22T12:25:07+01:00

admin commented

2026-01-22 12:25:07 +01:00

Originally created by @doctrinebot on GitHub (Oct 2, 2009).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user itoijala:

DateTimeType does not expect the value to be null, both conversions ignore this possibility. This bug is especially annoying when converting from the database to PHP. The user does not expect to get false as a value for a datetime field. False is returned by DateTime when null is given. Null should be returned as the PHP value. Converting to the database from PHP would result in an error, since $value would be null.

Simple fix:

OLD:

public function convertToDatabaseValue($value, AbstractPlatform $platform)
    {
    return $value->format($platform->getDateTimeFormatString());
    }

    public function convertToPHPValue($value, AbstractPlatform $platform)
    {
    return \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value);
    }

NEW:

public function convertToDatabaseValue($value, AbstractPlatform $platform)
    {
        if ($value !== null)
        {
            return $value->format($platform->getDateTimeFormatString());
        }
        else
        {
            return null;
        }
    }

    public function convertToPHPValue($value, AbstractPlatform $platform)
    {
        if ($value !== null)
        {
            return \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value);
        }
        else
        {
            return null;
        }
    }

Originally created by @doctrinebot on GitHub (Oct 2, 2009). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user itoijala: DateTimeType does not expect the value to be null, both conversions ignore this possibility. This bug is especially annoying when converting from the database to PHP. The user does not expect to get false as a value for a datetime field. False is returned by DateTime when null is given. Null should be returned as the PHP value. Converting to the database from PHP would result in an error, since $value would be null. Simple fix: OLD: ``` public function convertToDatabaseValue($value, AbstractPlatform $platform) { return $value->format($platform->getDateTimeFormatString()); } public function convertToPHPValue($value, AbstractPlatform $platform) { return \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value); } ``` NEW: ``` public function convertToDatabaseValue($value, AbstractPlatform $platform) { if ($value !== null) { return $value->format($platform->getDateTimeFormatString()); } else { return null; } } public function convertToPHPValue($value, AbstractPlatform $platform) { if ($value !== null) { return \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value); } else { return null; } } ```

admin added the Bug label 2026-01-22 12:25:07 +01:00

admin closed this issue

2026-01-22 12:25:07 +01:00

admin commented

2026-01-22 12:25:08 +01:00

@doctrinebot commented on GitHub (Oct 3, 2009):

Comment created by itoijala:

The same problem exists in DateType an TimeType as well. The same kind of fix should work.

@doctrinebot commented on GitHub (Oct 3, 2009): Comment created by itoijala: The same problem exists in DateType an TimeType as well. The same kind of fix should work.

admin commented

2026-01-22 12:25:09 +01:00

@doctrinebot commented on GitHub (Oct 3, 2009):

Comment created by @guilhermeblanco:

In changeset http://trac.doctrine-project.org/changeset/6418 I committed a fix to this report!

Thanks for report and patch!

@doctrinebot commented on GitHub (Oct 3, 2009): Comment created by @guilhermeblanco: In changeset http://trac.doctrine-project.org/changeset/6418 I committed a fix to this report! Thanks for report and patch!

admin commented

2026-01-22 12:25:09 +01:00

@doctrinebot commented on GitHub (Oct 3, 2009):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Oct 3, 2009): Issue was closed with resolution "Fixed"

admin referenced this issue

2026-01-22 15:56:03 +01:00

[PR #41] [CLOSED] [DDC-1085] Allow setting custom default classes for EntityManager and EntityRepository #7626

Sign in to join this conversation.