mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-3304: [EntityGenerator] Embeddables properties and methods are broken #4085
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Sep 11, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user phansys:
EntityGenerator creates broken properties for embeddables. Given the example classes exposed in http://docs.doctrine-project.org/en/latest/tutorials/embeddables.html (User, Address), EntityGenerator creates wrong associations in User entity. Instead of this:
I get this:
And the same for its getters and setters.
I'll try to do a PR when I found a way to solve this.
@doctrinebot commented on GitHub (Sep 11, 2014):
@doctrinebot commented on GitHub (Sep 11, 2014):
Comment created by @deeky666:
[~phansys] which version of ORM are you using? If you are using latest master, this might be related to PR: https://github.com/doctrine/doctrine2/pull/1105
It looks like it broke the EntityGenerator. Can you confirm?
@doctrinebot commented on GitHub (Sep 11, 2014):
Comment created by phansys:
Confirmed @deeky666, on rev
d9b43dc649(d9b43dc649).Thank you!
@doctrinebot commented on GitHub (Sep 11, 2014):
Comment created by phansys:
I've tried with rev
8a3def097f(previous to PR#1105) and the result is the same broken structure.@doctrinebot commented on GitHub (Sep 11, 2014):
Comment created by @deeky666:
[~phansys] thanks for your feedback. I will see if I have time tomorrow to look into this issue.
@doctrinebot commented on GitHub (Sep 12, 2014):
Comment created by @deeky666:
Had a quick look into the issue and recognized that embeddables are not taken into account at all at the moment. Working on a solution...
@doctrinebot commented on GitHub (Sep 12, 2014):
Comment created by @deeky666:
Patch provided in PR: https://github.com/doctrine/doctrine2/pull/1135
@doctrinebot commented on GitHub (Sep 12, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1135] was assigned:
https://github.com/doctrine/doctrine2/pull/1135
@doctrinebot commented on GitHub (Sep 12, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1135] was closed:
https://github.com/doctrine/doctrine2/pull/1135
@doctrinebot commented on GitHub (Sep 12, 2014):
Comment created by @deeky666:
Fixed in commit:
f12c311a79@doctrinebot commented on GitHub (Sep 12, 2014):
Issue was closed with resolution "Fixed"
@doctrinebot commented on GitHub (Sep 13, 2014):
Comment created by phansys:
Thanks [~deeky666].
@doctrinebot commented on GitHub (Oct 19, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-1105] was assigned:
https://github.com/doctrine/doctrine2/pull/1105