doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-3208: Merge DDC-3160 back into 2.4.x #3972

New Issue
Closed
opened 2026-01-22 14:32:34 +01:00 by admin · 7 comments
admin commented 2026-01-22 14:32:34 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Jul 6, 2014).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user @ocramius:

DDC-3160 should be backported to 2.4.4 once user feedback is collected.

Originally created by @doctrinebot on GitHub (Jul 6, 2014). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user @ocramius: [DDC-3160](http://www.doctrine-project.org/jira/browse/DDC-3160) should be backported to 2.4.4 once user feedback is collected.
admin closed this issue 2026-01-22 14:32:35 +01:00
admin commented 2026-01-22 14:32:36 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 6, 2014):

@doctrinebot commented on GitHub (Jul 6, 2014): - is referenced by [DDC-2996: UnitOfWork::recomputeSingleEntityChangeSet() will not add a new change set](http://www.doctrine-project.org/jira/browse/DDC-2996)
admin commented 2026-01-22 14:32:36 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 6, 2014):

Comment created by kbond:

I ran the DoctrineExtensions test suite with ORM 2.4 with this fix and it passed.

@doctrinebot commented on GitHub (Jul 6, 2014): Comment created by kbond: I ran the DoctrineExtensions test suite with ORM 2.4 with this fix and it passed.
admin commented 2026-01-22 14:32:36 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 6, 2014):

Comment created by zimmermanj42:

For the project I was working on where I started having issues with the 2.4.3 update and Atlantic18/DoctrineExtensions, the DDC-3160 solution did fix the problems that I was seeing. Granted, I am only using the Tree portion of that library, I cannot say anything about the other parts of it.

I just ran a test with the latest DoctrineExtensions code. These are the results I get with running Doctrine 2.4.3:

FAILURES!
Tests: 411, Assertions: 1760, Errors: 71, Skipped: 62.

When I patch up the Doctrine 2.4.3 branch with the DDC-3160 fix, I get much better results:

OK, but incomplete, skipped, or risky tests!
Tests: 411, Assertions: 2410, Skipped: 62.

From what I can tell, this does seem to fix the DoctrineExtensions issues which I believe was eventually tracked down to being caused by the DDC-2996 fix.

@doctrinebot commented on GitHub (Jul 6, 2014): Comment created by zimmermanj42: For the project I was working on where I started having issues with the 2.4.3 update and Atlantic18/DoctrineExtensions, the [DDC-3160](http://www.doctrine-project.org/jira/browse/DDC-3160) solution did fix the problems that I was seeing. Granted, I am only using the Tree portion of that library, I cannot say anything about the other parts of it. I just ran a test with the latest DoctrineExtensions code. These are the results I get with running Doctrine 2.4.3: FAILURES! Tests: 411, Assertions: 1760, Errors: 71, Skipped: 62. When I patch up the Doctrine 2.4.3 branch with the [DDC-3160](http://www.doctrine-project.org/jira/browse/DDC-3160) fix, I get much better results: OK, but incomplete, skipped, or risky tests! Tests: 411, Assertions: 2410, Skipped: 62. From what I can tell, this does seem to fix the DoctrineExtensions issues which I believe was eventually tracked down to being caused by the [DDC-2996](http://www.doctrine-project.org/jira/browse/DDC-2996) fix.
admin commented 2026-01-22 14:32:37 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 8, 2014):

Comment created by ericcoleman:

Patch is working for us.

@doctrinebot commented on GitHub (Jul 8, 2014): Comment created by ericcoleman: Patch is working for us.
admin commented 2026-01-22 14:32:37 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 10, 2014):

Comment created by @ocramius:

Going to merge this back into 2.4.x asap

@doctrinebot commented on GitHub (Jul 10, 2014): Comment created by @ocramius: Going to merge this back into 2.4.x asap
admin commented 2026-01-22 14:32:38 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 11, 2014):

Comment created by @ocramius:

Merged at 5c5abb6771

@doctrinebot commented on GitHub (Jul 11, 2014): Comment created by @ocramius: Merged at https://github.com/doctrine/doctrine2/commit/5c5abb6771c1f5ab8318f76aed79ce1da8a0300d
admin commented 2026-01-22 14:32:38 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jul 11, 2014):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Jul 11, 2014): Issue was closed with resolution "Fixed"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#3972
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?