mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-3197: [GH-1074] [DDC-3160] Alternate fix for DDC-2996 bug #3962
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Jun 26, 2014).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of zimmermanj42:
Url: https://github.com/doctrine/doctrine2/pull/1074
Message:
The fix implemented for DDC-2996 seems to have broken quite a bit of code outside of Doctrine (for instance, the popular DoctrineExtensions project).
I'm not too well versed in Doctrine internals, but looking at the fix, I found it odd that an entity would live in both the insertion and update tracking in the unit of work.
This implementation should fix the case described in DDC-2996, while not creating any side effects with objects that are scheduled to be inserted.
I've ran this test with the Doctrine test suite and have also tested this change with the DoctrineExtensions project; unless I'm doing something wrong, it seems to have good results.
Again, I'm not too well versed in the inner workings of Doctrine, but I did a little research, poked around some code, and came up with this.