mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3190: [GH-1071] Setup::createConfiguration breaks Cache interface contract #3953
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Jun 25, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of VasekPurchart:
Url: https://github.com/doctrine/doctrine2/pull/1071
Message:
Method
setNamespaceis called inSetup::createConfiguration, but at the moment there can be an instance ofDoctrine\Common\Cache\Cache(when given in the 3rd parameter), which does not define this method. This method is defined inDoctrine\Common\Cache\CacheProviderfrom which are the defaults being instantiated in this method extended.So there should be an condition or the 3rd parameter should declare a dependency on
CacheProviderrather than justCacheinterface. Or maybe the namespace should be set only if the Cache instance is not given by the 3rd parameter (as proposed in this PR now), assuming that when someone is giving a ready instance of Cache, it is configured properly.If you want to take another approach, I can change this PR.
@doctrinebot commented on GitHub (Jun 26, 2014):
Comment created by @ocramius:
Merged:
22d71de2c3@doctrinebot commented on GitHub (Jun 26, 2014):
Issue was closed with resolution "Fixed"