DDC-3177: [GH-1063] singularize variable name on add/remove methods for EntityGenerator #3938

New Issue

admin · 2026-01-22T14:31:57+01:00

admin commented

2026-01-22 14:31:57 +01:00

Originally created by @doctrinebot on GitHub (Jun 19, 2014).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of FlorianLB:

Url: https://github.com/doctrine/doctrine2/pull/1063

Message:

Not a big change but corrects an error of plural.

Previously :

    public function addComment(EntityGeneratorComment $comments)
    {
        $this->comments[] = $comments;

        return $this;
    }

With this PR :

    public function addComment(EntityGeneratorComment $comment)
    {
        $this->comments[] = $comment;

        return $this;
    }

Originally created by @doctrinebot on GitHub (Jun 19, 2014). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user @doctrinebot: This issue is created automatically through a Github pull request on behalf of FlorianLB: Url: https://github.com/doctrine/doctrine2/pull/1063 Message: Not a big change but corrects an error of plural. Previously : ``` php public function addComment(EntityGeneratorComment $comments) { $this->comments[] = $comments; return $this; } ``` With this PR : ``` php public function addComment(EntityGeneratorComment $comment) { $this->comments[] = $comment; return $this; } ```

admin added the Bug label 2026-01-22 14:31:57 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#3938