mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-3055: table not escaped in orm:schema-tool:update if table already exists and needs to be altered #3791
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Mar 27, 2014).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user hilz.simon:
the schema tool had to alter a table which name needs to be escaped (and was properly configured to do so). this didnt work because the table name wasnt escaped. completely deleting the table in the db let the schema tool generate the correct querys with escaped table names.
@doctrinebot commented on GitHub (Mar 27, 2014):
Comment created by @ocramius:
[~hilz.simon] did you try this with master as well?
@doctrinebot commented on GitHub (Jun 19, 2014):
Comment created by Moinax:
Hi it seems to fail on version 2.4.3 too
@Rene-Sackers commented on GitHub (Feb 19, 2016):
Wow, just came across this. Has this not been fixed in the past 2 years? That's quite silly.
@Ocramius commented on GitHub (Feb 19, 2016):
@Eraknelo lots of bugs didn't get fixed in the last years. What's silly about that?
@Rene-Sackers commented on GitHub (Feb 19, 2016):
@Ocramius I had expected more people to run into this. Since, if you use the doctrine:generate:entity, and you do something like AppBundle:Namespace1/Namespace2/ClassName, it does
@ORM\Table(name="namespace1/namespace2/class_name")Surely more people have this issue? Or does nobody use namespaces or the entity generator?
@Ocramius commented on GitHub (Feb 19, 2016):
This is commonly considered misuse, if generation is used more than once. The ORM codegen tools are by far a reliable functionality (and never meant to be one)
@Rene-Sackers commented on GitHub (Feb 19, 2016):
@Ocramius Wait, wait. Using the generate entity tool to generate entities is commonly considered misuse? I don't quite understand.
I quite like it to just quickly create a class with some simple fields. Also avoids a lot of copy/paste errors, like repositoryClass= in the @ORM\Entity annotation, which I always forget to change when I do copy/paste an entity, due to lack of IDE validation.
@Ocramius commented on GitHub (Feb 19, 2016):
Yes, entity generation is by far the use-case scenario of the ORM. You are usually supposed to do the opposite: generate, update or generate migrations for the DB schema from your entity changes.