mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-3044: [GH-986] Add last modified time for metadata #3781
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Mar 22, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of c960657:
Url: https://github.com/doctrine/doctrine2/pull/986
Message:
This patch improves performance during development and does not affect production performance.
Currently, enabling the metadata cache during development gives a remarkable performance boost, but it requires that you manually flush the metadata cache when the metadata has been changed. When running console commands such as
console orm:schema-tool:update(see #979).With this change, metadata entries fetched from cache are checked for freshness using a quick last modified check. This is much faster than loading the actual metadata using the metadata driver. This allows you to enable the metadata cache during development without the need for manually flushing the metadata cache.
This PR is part 1 of 2. Part 2 is for the doctrine/common repository.
If this PR is accepted, it allows us to optimize the auto-generate proxy classes feature by comparing the last modified time for the metadata with the modified timestamp of the generated file.
@doctrinebot commented on GitHub (Jan 24, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-986] was labeled:
https://github.com/doctrine/doctrine2/pull/986
@doctrinebot commented on GitHub (Aug 31, 2015):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-986] was assigned:
https://github.com/doctrine/doctrine2/pull/986
@Ocramius commented on GitHub (Dec 11, 2015):
Closing as per discussion in #986