mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-300: RunSqlTask needs the ability to parse an SQL file #374
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Feb 3, 2010).
Originally assigned to: @guilhermeblanco on GitHub.
Jira issue originally created by user brandon.parise:
I made the following assumptions with the patch...
Should I assume differently? Or are there more assumptions I should consider?
@doctrinebot commented on GitHub (Feb 4, 2010):
Comment created by @beberlei:
My assumptions are phpMyAdmin biased. All statements are separated by ; - Lines dont matter. Problem here is that ; is a valid sign inside a literal.
@doctrinebot commented on GitHub (Feb 4, 2010):
Comment created by @guilhermeblanco:
We should not be so granular during this execution.
Also, OPTIMIZE, EXPLAIN, SHOW actually returns ResultSets and break the executeUpdate.
The correct way to do it would be using a RowSet support of PDOStatement.
The patch is ok, but a small modification and it'll be great to be merged. I'm assigning this issue to me and marking it as work in progress. I'll try to commit it tonight.
Cheers,
@doctrinebot commented on GitHub (Feb 4, 2010):
Comment created by @guilhermeblanco:
First draft for patch: http://pastie.org/809510
@doctrinebot commented on GitHub (Feb 5, 2010):
Comment created by @beberlei:
Problem is "nextRowset()" is not a method on the Doctrine\DBAL\Driver\Statement interface
@doctrinebot commented on GitHub (Mar 3, 2010):
Comment created by @guilhermeblanco:
In r7306 this issue was fixed.
@doctrinebot commented on GitHub (Mar 3, 2010):
Issue was closed with resolution "Fixed"
@doctrinebot commented on GitHub (Dec 13, 2015):
Imported 1 attachments from Jira into https://gist.github.com/58375ca36e51bcecb47d