mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-2992: [GH-958] wrong access modifiers "private" instead of "protected" #3721
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Feb 20, 2014).
Originally assigned to: @Ocramius on GitHub.
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of grytysek:
Url: https://github.com/doctrine/doctrine2/pull/958
Message:
In configuration is parameter:
that suggest that is designed to override in private bundles but when you try to do that it's nessesary to repeat entire body of methods in own class because of "private" access modifiers, i suggest to change them to 'protected' because without that it's makes extending this class more difficult and not clear to understand what is going on inside of this classes.
... I suggest to change this modifiers not only in this class...
@doctrinebot commented on GitHub (Feb 21, 2014):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-958] was closed:
https://github.com/doctrine/doctrine2/pull/958
@doctrinebot commented on GitHub (Feb 21, 2014):
Issue was closed with resolution "Won't Fix"