doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-299: Wrong parsing of 'on-delete' and 'on-update' attributes of join columns in xml mapping driver #371

New Issue
Closed
opened 2026-01-22 12:36:17 +01:00 by admin · 5 comments
admin commented 2026-01-22 12:36:17 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Feb 3, 2010).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user ignat:

  1. The error is in _getJoinColumnMapping method of Doctrine\ORM\Mapping\Driver\XmlDriver class where isset method corresponds to 'onDelete' and 'onUpdate' keys of $joinColumnElement, they must be 'on-delete' and 'on-update' respectively.
  2. 'new' operator missed in Doctrine\DBAL\Platforms\AbstractPlatform in getForeignKeyReferentialActionSql method when exception throws in default case.
Originally created by @doctrinebot on GitHub (Feb 3, 2010). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user ignat: 1) The error is in _getJoinColumnMapping method of Doctrine\ORM\Mapping\Driver\XmlDriver class where isset method corresponds to 'onDelete' and 'onUpdate' keys of $joinColumnElement, they must be 'on-delete' and 'on-update' respectively. 2) 'new' operator missed in Doctrine\DBAL\Platforms\AbstractPlatform in getForeignKeyReferentialActionSql method when exception throws in default case.
admin added the Bug label 2026-01-22 12:36:17 +01:00
admin closed this issue 2026-01-22 12:36:19 +01:00
admin commented 2026-01-22 12:36:19 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Feb 3, 2010):

Comment created by romanb:

I think nr. 1 is already fixed in trunk.

@doctrinebot commented on GitHub (Feb 3, 2010): Comment created by romanb: I think nr. 1 is already fixed in trunk.
admin commented 2026-01-22 12:36:21 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Feb 3, 2010):

Comment created by ignat:

sorry i missed it. I'll be more attentive next time

@doctrinebot commented on GitHub (Feb 3, 2010): Comment created by ignat: sorry i missed it. I'll be more attentive next time
admin commented 2026-01-22 12:36:21 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Feb 3, 2010):

Comment created by @beberlei:

I committed the fix for 1. two days ago, so no problem :-)

@doctrinebot commented on GitHub (Feb 3, 2010): Comment created by @beberlei: I committed the fix for 1. two days ago, so no problem :-)
admin commented 2026-01-22 12:36:22 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Feb 7, 2010):

Comment created by @beberlei:

Is already fixed.

@doctrinebot commented on GitHub (Feb 7, 2010): Comment created by @beberlei: Is already fixed.
admin commented 2026-01-22 12:36:23 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Feb 7, 2010):

Issue was closed with resolution "Duplicate"

@doctrinebot commented on GitHub (Feb 7, 2010): Issue was closed with resolution "Duplicate"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?