DDC-291: Stip trailing whitespaces from all files and introduce pre-commit hook #359

Closed
opened 2026-01-22 12:36:01 +01:00 by admin · 3 comments
Owner

Originally created by @doctrinebot on GitHub (Jan 31, 2010).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

Creating patches for doctrine 2 is a bit of a hazzle for some since we have lots of trailing whitespaces in files.

We should remove them once in a huge commit and then insert a pre-commit hook on all *.php files to keep the code clean.

Originally created by @doctrinebot on GitHub (Jan 31, 2010). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: Creating patches for doctrine 2 is a bit of a hazzle for some since we have lots of trailing whitespaces in files. We should remove them once in a huge commit and then insert a pre-commit hook on all *.php files to keep the code clean.
admin added the Improvement label 2026-01-22 12:36:01 +01:00
admin closed this issue 2026-01-22 12:36:02 +01:00
Author
Owner

@doctrinebot commented on GitHub (Feb 10, 2010):

Comment created by romanb:

According to the mailing lists, a pre-commit hook is regarded as a bad idea by most people.

@doctrinebot commented on GitHub (Feb 10, 2010): Comment created by romanb: According to the mailing lists, a pre-commit hook is regarded as a bad idea by most people.
Author
Owner

@doctrinebot commented on GitHub (Feb 26, 2010):

Comment created by @beberlei:

Denied

@doctrinebot commented on GitHub (Feb 26, 2010): Comment created by @beberlei: Denied
Author
Owner

@doctrinebot commented on GitHub (Feb 26, 2010):

Issue was closed with resolution "Won't Fix"

@doctrinebot commented on GitHub (Feb 26, 2010): Issue was closed with resolution "Won't Fix"
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#359