DDC-2844: Doctrine\ORM\Query\QueryException raised when using Criteria object with more than one condition in repository. #3550

New Issue

Closed

opened 2026-01-22 14:22:10 +01:00 by admin · 14 comments

admin commented 2026-01-22 14:22:10 +01:00

Owner

Copy Link

Originally created by @doctrinebot on GitHub (Dec 7, 2013).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user yanakey:

$userRepository = $em->getRepository ('User\Entity\User');
$date = '2013-12-02';
$dateFrom = new \DateTime ($date);
$fateTo = (new \DateTime ($date))->add (new \DateInterval ('P1D');

// OK
$criteria = new \Doctrine\Common\Collections\Criteria ();
$criteria
    ->where ($criteria->expr ()->gte ('signedIn', $dateFrom))
    ->andWhere ($criteria->expr ()->lt ('signedIn', $dateTo));
var_dump ($userRepository->matching ($criteria));


// NOT OK - Doctrine\ORM\Query\QueryException "Invalid parameter number: number of bound variables does not match number of tokens"
$criteria = new \Doctrine\Common\Collections\Criteria ();
$criteria
    ->where ($criteria->expr ()->gte ('user.signedIn', $dateFrom))
    ->andWhere ($criteria->expr ()->lt ('user.signedIn', $dateTo));
var_dump ($userRepository->createQueryBuilder ('user')->addCriteria ($criteria)->getQuery ()->getResult ());


// NOT OK - Doctrine\ORM\Query\QueryException "Invalid parameter number: number of bound variables does not match number of tokens"
$criteria
    ->where ($criteria->expr ()->eq ('user.active', true))
    ->andWhere ($criteria->expr ()->eq ('user.active', true));
    //->orWhere ($criteria->expr ()->eq ('user.active', true));
var_dump ($userRepository->createQueryBuilder ('user')->addCriteria ($criteria)->getQuery ()->getResult ());

Originally created by @doctrinebot on GitHub (Dec 7, 2013). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user yanakey: ``` $userRepository = $em->getRepository ('User\Entity\User'); $date = '2013-12-02'; $dateFrom = new \DateTime ($date); $fateTo = (new \DateTime ($date))->add (new \DateInterval ('P1D'); // OK $criteria = new \Doctrine\Common\Collections\Criteria (); $criteria ->where ($criteria->expr ()->gte ('signedIn', $dateFrom)) ->andWhere ($criteria->expr ()->lt ('signedIn', $dateTo)); var_dump ($userRepository->matching ($criteria)); // NOT OK - Doctrine\ORM\Query\QueryException "Invalid parameter number: number of bound variables does not match number of tokens" $criteria = new \Doctrine\Common\Collections\Criteria (); $criteria ->where ($criteria->expr ()->gte ('user.signedIn', $dateFrom)) ->andWhere ($criteria->expr ()->lt ('user.signedIn', $dateTo)); var_dump ($userRepository->createQueryBuilder ('user')->addCriteria ($criteria)->getQuery ()->getResult ()); // NOT OK - Doctrine\ORM\Query\QueryException "Invalid parameter number: number of bound variables does not match number of tokens" $criteria ->where ($criteria->expr ()->eq ('user.active', true)) ->andWhere ($criteria->expr ()->eq ('user.active', true)); //->orWhere ($criteria->expr ()->eq ('user.active', true)); var_dump ($userRepository->createQueryBuilder ('user')->addCriteria ($criteria)->getQuery ()->getResult ()); ```

admin added the Bug label 2026-01-22 14:22:10 +01:00

admin closed this issue 2026-01-22 14:22:10 +01:00

admin commented 2026-01-22 14:22:12 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by cordoval:

so I have reproduced the problem https://github.com/cordoval/symfony-standard/pull/8/files

what i think is happening is problem lies on Criteria api not being able to handle well multiple parameters in expression

  private '*dql' => string 'SELECT user FROM Acme\DemoBundle\Entity\User user WHERE user.signedIn >= :user_signedIn AND user.signedIn < :user*signedIn' (length=122)

it tries to figure out a name and fails to name them properly on parameters internal property.

I am working on a fix.

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by cordoval: so I have reproduced the problem https://github.com/cordoval/symfony-standard/pull/8/files what i think is happening is problem lies on Criteria api not being able to handle well multiple parameters in expression ``` private '*dql' => string 'SELECT user FROM Acme\DemoBundle\Entity\User user WHERE user.signedIn >= :user_signedIn AND user.signedIn < :user*signedIn' (length=122) ``` it tries to figure out a name and fails to name them properly on parameters internal property. I am working on a fix.

admin commented 2026-01-22 14:22:12 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by cordoval:

writing failing test first at QueryBuilderTest::testAddCriteriaWhere() here https://github.com/doctrine/doctrine2/pull/874
now working on seeing why that commit in the description may have not solved these other cases

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by cordoval: writing failing test first at QueryBuilderTest::testAddCriteriaWhere() here https://github.com/doctrine/doctrine2/pull/874 now working on seeing why that commit in the description may have not solved these other cases

admin commented 2026-01-22 14:22:12 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by cordoval:

this should be closed as it is working on master :)

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by cordoval: this should be closed as it is working on master :)

admin commented 2026-01-22 14:22:12 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-874] was closed:
https://github.com/doctrine/doctrine2/pull/874

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by @doctrinebot: A related Github Pull-Request [GH-874] was closed: https://github.com/doctrine/doctrine2/pull/874

admin commented 2026-01-22 14:22:14 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by @beberlei:

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by @beberlei: ##

admin commented 2026-01-22 14:22:15 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by @ocramius:

As [~cordoval] said, this seems to be a non-issue. I provided tests to validate that at https://github.com/doctrine/doctrine2/pull/875

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by @ocramius: As [~cordoval] said, this seems to be a non-issue. I provided tests to validate that at https://github.com/doctrine/doctrine2/pull/875

admin commented 2026-01-22 14:22:16 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-875] was closed:
https://github.com/doctrine/doctrine2/pull/875

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by @doctrinebot: A related Github Pull-Request [GH-875] was closed: https://github.com/doctrine/doctrine2/pull/875

admin commented 2026-01-22 14:22:16 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Comment created by @ocramius:

Tests provided at ce914bef3f

@doctrinebot commented on GitHub (Dec 14, 2013): Comment created by @ocramius: Tests provided at https://github.com/doctrine/doctrine2/commit/ce914bef3fddebb4b54f4353f5daad6241802d9d

admin commented 2026-01-22 14:22:19 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 14, 2013):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Dec 14, 2013): Issue was closed with resolution "Fixed"

admin commented 2026-01-22 14:22:22 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Jun 3, 2014):

Comment created by althaus:

Stumbled upon this issue today. As this is fixed in master, but not in the 2.4.1 or 2.4.2 release... is this expected to be part of another 2.4.x or only 2.5 as it's just a "unsupported case" and no bug? Would be great if someone could updated the "Fix Version/s" as it's definitely not resolved in 2.4.1.

@doctrinebot commented on GitHub (Jun 3, 2014): Comment created by althaus: Stumbled upon this issue today. As this is fixed in master, but not in the 2.4.1 or 2.4.2 release... is this expected to be part of another 2.4.x or only 2.5 as it's just a "unsupported case" and no bug? Would be great if someone could updated the "Fix Version/s" as it's definitely not resolved in 2.4.1.

admin commented 2026-01-22 14:22:22 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Jun 6, 2014):

Comment created by @ocramius:

[~althaus] do the tests in this issue run on 2.4.x?

@doctrinebot commented on GitHub (Jun 6, 2014): Comment created by @ocramius: [~althaus] do the tests in this issue run on 2.4.x?

admin commented 2026-01-22 14:22:23 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Jun 10, 2014):

Comment created by althaus:

[~ocramius], which tests do you mean exactly?

Comparing the Doctrine\ORM\Query\QueryExpressionVisitor of the just released 2.4.3 and master the 2.4.x branch is still missing the fix.

@doctrinebot commented on GitHub (Jun 10, 2014): Comment created by althaus: [~ocramius], which tests do you mean exactly? Comparing the `Doctrine\ORM\Query\QueryExpressionVisitor` of the just released [2.4.3](https://github.com/doctrine/doctrine2/blob/v2.4.3/lib/Doctrine/ORM/Query/QueryExpressionVisitor.php#L135) and [master](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/QueryExpressionVisitor.php#L132) the 2.4.x branch is still missing the fix.

admin commented 2026-01-22 14:22:23 +01:00

Author

Owner

Copy Link

@leobedrosian commented on GitHub (Nov 8, 2017):

Just ran into this myself. The problem is with the parameter binding logic in Doctrine\ORM\Query\QueryExpressionVisitor. The walkComparison method does not properly handle parameter naming such that parameters are assigned unique names to which the right values can be bound. Instead, the same parameter names are being used/reused and overwritten with each condition on the same column. This is definitely fixed in the master branch (currently v2.5) but the problem exists in 2.4.

The simplest solution is to add an incremental, numerical suffix to parameter names based on the number of parameters defined so that every single parameter is assured to be unique for value binding purposes. Ex (line 137):

$parameterName = str_replace('.', '_', $comparison->getField()) . count($this->parameters);

In the master branch (currently v2.5), there's some iteration on parameter names happening to resolve this issue (lines 150 to 155) but this seems needlessly inefficient and overkill:

foreach($this->parameters as $parameter) { if($parameter->getName() === $parameterName) { $parameterName .= '_' . count($this->parameters); break; } }

Reference file: https://github.com/doctrine/doctrine2/blob/2.5/lib/Doctrine/ORM/Query/QueryExpressionVisitor.php

@leobedrosian commented on GitHub (Nov 8, 2017): Just ran into this myself. The problem is with the parameter binding logic in `Doctrine\ORM\Query\QueryExpressionVisitor`. The `walkComparison` method _does not_ properly handle parameter naming _such that_ parameters are assigned unique names to which the right values can be bound. Instead, the _same_ parameter names are being used/reused and overwritten with each condition on the same column. This is definitely fixed in the master branch (currently v2.5) but the problem exists in 2.4. The simplest solution is to add an incremental, numerical suffix to parameter names based on the number of parameters defined so that every single parameter is assured to be unique for value binding purposes. Ex (line 137): `$parameterName = str_replace('.', '_', $comparison->getField()) . count($this->parameters);` In the master branch (currently v2.5), there's some iteration on parameter names happening to resolve this issue (lines 150 to 155) but this seems needlessly inefficient and overkill: `foreach($this->parameters as $parameter) { if($parameter->getName() === $parameterName) { $parameterName .= '_' . count($this->parameters); break; } }` Reference file: https://github.com/doctrine/doctrine2/blob/2.5/lib/Doctrine/ORM/Query/QueryExpressionVisitor.php

admin commented 2026-01-22 14:22:25 +01:00

Author

Owner

Copy Link

@lcobucci commented on GitHub (Nov 21, 2017):

@hbedrosian clarifying one thing: master is v2.6.x-dev and NOT v2.5, v2.5 is on 2.5 branch (which you referenced correctly). 2.4 is not supported anymore too.

but this seems needlessly inefficient and overkill

If you have any suggestion on how to improve it, please send a PR 😄

@lcobucci commented on GitHub (Nov 21, 2017): @hbedrosian clarifying one thing: `master` is `v2.6.x-dev` and NOT `v2.5`, `v2.5` is on `2.5` branch (which you referenced correctly). `2.4` is not supported anymore too. > but this seems needlessly inefficient and overkill If you have any suggestion on how to improve it, please send a PR 😄

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label Bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#3550