mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-2838: Leaky abstraction when applying Criteria to hydrated/non-hydrated PersistentCollection #3543
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Dec 3, 2013).
Originally assigned to: @Ocramius, @alcaeus on GitHub.
Jira issue originally created by user ptlis:
When applying a Criteria to a PersistentCollection that has been hydrated the field names must be camel case, if the collection has not yet been hydrated the field names must be underscore separated.
The github repo linked here contains a simplified testcase for the matrix of hydrated/non-hydrated entities and camel case/underscore separated fields.
https://github.com/ptlis/DoctrineTestcase
@doctrinebot commented on GitHub (Dec 3, 2013):
@doctrinebot commented on GitHub (Aug 18, 2014):
Comment created by @ocramius:
We can't check out an entire project just to test a bug.
Please write an actual functional test case that can be integrated into the Doctrine ORM test suite.
@doctrinebot commented on GitHub (Aug 20, 2014):
Comment created by ptlis:
Hi,
i'm happy to do so - i'll take a look at this over the weekend.
@doctrinebot commented on GitHub (Dec 12, 2014):
Comment created by derula:
[~ptlis]: Any progress on this? This is currently an issue for us as well and hope to get fixed. I could look into converting it to a test for integration with the test suite if you don't have the time... but it might take a while since I have no experience with the requirements that should be met. (Plus, I am not sure how tightly coupled it is with your project)
@doctrinebot commented on GitHub (Dec 17, 2014):
Comment created by derula:
Hi [ocramius], [ptlis],
I attached a functional Test that integrates with the test suite. Please let me know if I should issue a PR, and I'll do that this evening.
@doctrinebot commented on GitHub (Dec 26, 2014):
Comment created by floeh:
+1
@doctrinebot commented on GitHub (Jun 26, 2015):
Comment created by derula:
My idea to solve this would go like this:
The only thing that's causing me a headache is that ideally, there should be code sharing in some form between the matching() implementations of ObjectCollection and PersistentCollection, because both will use class metadata. Maybe this can be achieved somehow using a trait?
If you like the idea, I could look into it further.
@ostrolucky commented on GitHub (May 14, 2017):
I tried this and it seems to be no longer reproducible with provided demo repository. @ptlis can you confirm?
@ostrolucky commented on GitHub (May 22, 2017):
This has been fixed via
32d524547eyou can close this guys @Ocramius@alcaeus commented on GitHub (May 23, 2017):
Thanks @ostrolucky!