DDC-258: DiscriminatorMap Ordering Affects Mapping #320

New Issue

admin · 2026-01-22T12:34:36+01:00

admin commented

2026-01-22 12:34:36 +01:00

Originally created by @doctrinebot on GitHub (Jan 15, 2010).

Jira issue originally created by user mridgway:

In an inheritance tree, I have a super class with three subclasses. Two of the subclasses have a 'title' and 'description' field, but one of those has an extra field. The third class doesn't share any properties, but demonstrates the reasoning for not having 'title' and 'description' in the super class.

So, the problem I'm getting is that only one of these classes can work at a time, depending on which is first in the DiscriminatorMap. The SQL query performs left joins on all of the tables and uses aliases to keep the common fields separated. The mapper doesn't seem to be using the aliases when it maps the properties to the object. It seems override properties even if they aren't in the correct table.

Example:

/****
 * @Entity
 * @Table(name="Content")
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="type", type="string")
 * @DiscriminatorMap({"class1" = "Class1", "class2" = "Class2", "class3"="Class3"})
 */
abstract class Super
{
    /****
     * @Id @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
    */
    protected $id;
}

/****
 * @Entity
 */
class Class1 extends Super
{
    /****
     * @Column(name="title", type="string", length="150")
     */
    protected $title;

    /****
     * @Column(name="content", type="string", length="500")
     */
    protected $description;
}

/****
 * @Entity
 */
class Class2 extends Super
{
    /****
     * @Column(name="title", type="string", length="150")
     */
    protected $title;

    /****
     * @Column(name="content", type="string", length="500")
     */
    protected $description;

    /****
     * @Column(name="text", type="text")
     */
    protected $text;
}

/****
 * An extra class to demonstrate why title and description aren't in Super
 *
 * @Entity
 */
class Class3 extends Super
{
    /****
     * @Column(name="title", type="string", length="150")
     */
    protected $apples;

    /****
     * @Column(name="content", type="string", length="500")
     */
    protected $bananas;
}

The select for a Super of id 2 uses the following query (or similar):
noneSELECT t0.id, t0.type, t1.title, t1.description, t2.title, t2.description, t2.text, t3.apples, t3.bananas FROM Super t0 LEFT JOIN Class1 t1 ON t0.id = t1.id LEFT JOIN Class2 t2 ON t0.id = t2.id LEFT JOIN Class3 t3 ON t0.id = t3.id WHERE t0.id = 2;

Now, if the DiscriminatorMap is reordered, the joins change order as well, which seems to affect which fields actually get mapped to the object.

Originally created by @doctrinebot on GitHub (Jan 15, 2010). Jira issue originally created by user mridgway: In an inheritance tree, I have a super class with three subclasses. Two of the subclasses have a 'title' and 'description' field, but one of those has an extra field. The third class doesn't share any properties, but demonstrates the reasoning for not having 'title' and 'description' in the super class. So, the problem I'm getting is that only one of these classes can work at a time, depending on which is first in the DiscriminatorMap. The SQL query performs left joins on all of the tables and uses aliases to keep the common fields separated. The mapper doesn't seem to be using the aliases when it maps the properties to the object. It seems override properties even if they aren't in the correct table. Example: ``` none /**** * @Entity * @Table(name="Content") * @InheritanceType("JOINED") * @DiscriminatorColumn(name="type", type="string") * @DiscriminatorMap({"class1" = "Class1", "class2" = "Class2", "class3"="Class3"}) */ abstract class Super { /**** * @Id @Column(name="id", type="integer") * @GeneratedValue(strategy="AUTO") */ protected $id; } /**** * @Entity */ class Class1 extends Super { /**** * @Column(name="title", type="string", length="150") */ protected $title; /**** * @Column(name="content", type="string", length="500") */ protected $description; } /**** * @Entity */ class Class2 extends Super { /**** * @Column(name="title", type="string", length="150") */ protected $title; /**** * @Column(name="content", type="string", length="500") */ protected $description; /**** * @Column(name="text", type="text") */ protected $text; } /**** * An extra class to demonstrate why title and description aren't in Super * * @Entity */ class Class3 extends Super { /**** * @Column(name="title", type="string", length="150") */ protected $apples; /**** * @Column(name="content", type="string", length="500") */ protected $bananas; } ``` The select for a Super of id 2 uses the following query (or similar): `noneSELECT t0.id, t0.type, t1.title, t1.description, t2.title, t2.description, t2.text, t3.apples, t3.bananas FROM Super t0 LEFT JOIN Class1 t1 ON t0.id = t1.id LEFT JOIN Class2 t2 ON t0.id = t2.id LEFT JOIN Class3 t3 ON t0.id = t3.id WHERE t0.id = 2;` Now, if the DiscriminatorMap is reordered, the joins change order as well, which seems to affect which fields actually get mapped to the object.

admin added the Bug label 2026-01-22 12:34:37 +01:00

admin closed this issue

2026-01-22 12:34:38 +01:00

admin commented

2026-01-22 12:34:40 +01:00

@doctrinebot commented on GitHub (Jan 18, 2010):

Comment created by mridgway:

It appears it doesn't have to do with the table name, but with the actual property name. Changing the property column names in one of the classes still gives the same results, but changing the property names does fix it.

@doctrinebot commented on GitHub (Jan 18, 2010): Comment created by mridgway: It appears it doesn't have to do with the table name, but with the actual property name. Changing the property column names in one of the classes still gives the same results, but changing the property names does fix it.

admin commented

2026-01-22 12:34:41 +01:00

@doctrinebot commented on GitHub (Jan 18, 2010):

Comment created by mridgway:

Formatting to fix horizontal scroll.

@doctrinebot commented on GitHub (Jan 18, 2010): Comment created by mridgway: Formatting to fix horizontal scroll.

admin commented

2026-01-22 12:34:43 +01:00

@doctrinebot commented on GitHub (Feb 20, 2010):

Comment created by @beberlei:

@Roman - I just read jwages slides on Dc2 and he mentioned in an inheritance scenario no field is allowed to be defined twice, isn't that the case here which produces this problems?

@doctrinebot commented on GitHub (Feb 20, 2010): Comment created by @beberlei: @Roman - I just read jwages slides on Dc2 and he mentioned in an inheritance scenario no field is allowed to be defined twice, isn't that the case here which produces this problems?

admin commented

2026-01-22 12:34:45 +01:00

@doctrinebot commented on GitHub (Feb 22, 2010):

Comment created by romanb:

@Benjamin: Shouldnt be, because the restriction refers to classes who inherit from each other.

Say, if Class2 would extend Class1 in this example, that would be a violation because Class2 would actually have 2 x title/description.

@doctrinebot commented on GitHub (Feb 22, 2010): Comment created by romanb: @Benjamin: Shouldnt be, because the restriction refers to classes who inherit from each other. Say, if Class2 would extend Class1 in this example, that would be a violation because Class2 would actually have 2 x title/description.

admin commented

2026-01-22 12:34:46 +01:00

@doctrinebot commented on GitHub (Feb 26, 2010):

Comment created by @beberlei:

Verified, Test-Case attached for Roman

@doctrinebot commented on GitHub (Feb 26, 2010): Comment created by @beberlei: Verified, Test-Case attached for Roman

admin commented

2026-01-22 12:34:46 +01:00

@doctrinebot commented on GitHub (Mar 5, 2010):

Comment created by romanb:

Should be fixed now. Testcase is committed.

@doctrinebot commented on GitHub (Mar 5, 2010): Comment created by romanb: Should be fixed now. Testcase is committed.

admin commented

2026-01-22 12:34:47 +01:00

@doctrinebot commented on GitHub (Mar 5, 2010):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Mar 5, 2010): Issue was closed with resolution "Fixed"

admin commented

2026-01-22 12:34:48 +01:00

@doctrinebot commented on GitHub (Dec 13, 2015):

Imported 1 attachments from Jira into https://gist.github.com/778b3c6ba10e47829bc6

10398_DDC258Test.php

@doctrinebot commented on GitHub (Dec 13, 2015): Imported 1 attachments from Jira into https://gist.github.com/778b3c6ba10e47829bc6 - [10398_DDC258Test.php](https://gist.github.com/778b3c6ba10e47829bc6#file-10398_DDC258Test-php)

admin referenced this issue

2026-01-22 15:58:01 +01:00

[PR #320] [CLOSED] Fix DDC-1719 #8025

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#320