doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-2507: [GH-698] Fix for [DDC-2506] CTI JOINs and WITH conditionals #3146

New Issue
Open
opened 2026-01-22 14:13:45 +01:00 by admin · 0 comments
admin commented 2026-01-22 14:13:45 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Jun 14, 2013).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of mattjanssen:

Url: https://github.com/doctrine/doctrine2/pull/698

Message:

http://www.doctrine-project.org/jira/browse/DDC-2506

Moved the SqlWalker::walkConditionalExpression() out of walkJoin() and into walkJoinAssociationDeclaration() after the base class JOIN but _before_ the _generateClassTableInheritanceJoins(), thus allowing WITH conditions in Class Table Inheritance joins to apply correctly.

On a side note, I'm not able to get phpunit to run (even on a clean Master) so I'm leaving the testing up to Travis.

Originally created by @doctrinebot on GitHub (Jun 14, 2013). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user @doctrinebot: This issue is created automatically through a Github pull request on behalf of mattjanssen: Url: https://github.com/doctrine/doctrine2/pull/698 Message: http://www.doctrine-project.org/jira/browse/[DDC-2506](http://www.doctrine-project.org/jira/browse/DDC-2506) Moved the `SqlWalker::walkConditionalExpression()` out of `walkJoin()` and into `walkJoinAssociationDeclaration()` after the base class JOIN but **_before**_ the `_generateClassTableInheritanceJoins()`, thus allowing WITH conditions in Class Table Inheritance joins to apply correctly. On a side note, I'm not able to get phpunit to run (even on a clean Master) so I'm leaving the testing up to Travis.
admin added the Bug label 2026-01-22 14:13:45 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#3146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?