doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-2421: Many-To-Many relation creation failed when using non PK entity field #3036

New Issue
Closed
opened 2026-01-22 14:10:28 +01:00 by admin · 5 comments
admin commented 2026-01-22 14:10:28 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Apr 29, 2013).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user jedi_bc:

Given these entities :

/****
 * Class Domain
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_domains")
 */
class Domain
{
    /****
     * @var string
     *
     * @ORM\Id
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';
}

/****
 * Class Web
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_webs",
 *          uniqueConstraints={@ORM\UniqueConstraint(name="web_unique",columns={"name", "domain"})}
 * )
 */
class Web
{
    /****
     * @var integer
     *
     * @ORM\Id
     * @ORM\GeneratedValue
     * @ORM\Column(type="integer", nullable=false)
     */
    protected $id;

    /****
     * @var string
     *
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /****
     * @var Domain
     *
     * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE")
     */
    protected $domain;
}

/****
 * Class WebsGroup
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_websgroups",
 *          uniqueConstraints={@ORM\UniqueConstraint(name="websgroup_unique",columns={"name", "domain"})}
 * )
 */
class WebsGroup
{
    /****
     * @var integer
     *
     * @ORM\Id
     * @ORM\GeneratedValue
     * @ORM\Column(type="integer", nullable=false)
     */
    protected $id;

    /****
     * @var string
     *
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /****
     * @var Domain
     *
     * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE")
     */
    protected $domain;

    /****
     * @var ArrayCollection
     *
     * @ORM\ManyToMany(targetEntity="Web", indexBy="id", fetch="EXTRA_LAZY")
     * @ORM\JoinTable(name="profils*websgroups*webs",
     *      joinColumns={
     * @ORM\JoinColumn(name="websgroup_id", referencedColumnName="id", onDelete="CASCADE"),
     * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          },
     *      inverseJoinColumns={
     * @ORM\JoinColumn(name="web_id", referencedColumnName="id", onDelete="CASCADE"),
     * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          }
     *      )
     */
    protected $webs;
}

I've got a domain, some web sites per domain and websgroups which group web sites. I want to be sure in my database that a web group from a domain D can contain only web sites from the very same domain but when calling the console tool for creating my schema it raise :

[Doctrine\ORM\ORMException]                                                                                                                                      
  Column name `domain` referenced for relation from Entity\WebsGroup towards Entity\Web does not exist.

It's because domain is already an association to an entity which and is not part of the primary key.

I've quick fixed getDefiningClass from Doctrine\ORM\Tools\SchemaTool to make it work but i really don't know if it's the proper way :

    private function getDefiningClass($class, $referencedColumnName)
    {
        $referencedFieldName = $class->getFieldName($referencedColumnName);

        if ($class->hasField($referencedFieldName)) {
            return array($class, $referencedFieldName);
        } else if (in_array($referencedColumnName, $class->getIdentifierColumnNames())) {
            // it seems to be an entity as foreign key
            foreach ($class->getIdentifierFieldNames() as $fieldName) {
                if ($class->hasAssociation($fieldName) && $class->getSingleAssociationJoinColumnName($fieldName) == $referencedColumnName) {
                    return $this->getDefiningClass(
                        $this->em->getClassMetadata($class->associationMappings[$fieldName]['targetEntity']),
                        $class->getSingleAssociationReferencedJoinColumnName($fieldName)
                    );
                }
            }
        } else if (in_array($referencedColumnName, $class->getAssociationNames())) {
            return $this->getDefiningClass(
                $this->em->getClassMetadata($class->associationMappings[$referencedColumnName]['targetEntity']),
                $class->getSingleAssociationReferencedJoinColumnName($referencedColumnName)
            );
        }

        return null;
    }
Originally created by @doctrinebot on GitHub (Apr 29, 2013). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user jedi_bc: Given these entities : ``` /**** * Class Domain * * @ORM\Entity * @ORM\Table(name="profils_domains") */ class Domain { /**** * @var string * * @ORM\Id * @ORM\Column(type="string", length=22, nullable=false) */ protected $name = ''; } ``` ``` /**** * Class Web * * @ORM\Entity * @ORM\Table(name="profils_webs", * uniqueConstraints={@ORM\UniqueConstraint(name="web_unique",columns={"name", "domain"})} * ) */ class Web { /**** * @var integer * * @ORM\Id * @ORM\GeneratedValue * @ORM\Column(type="integer", nullable=false) */ protected $id; /**** * @var string * * @ORM\Column(type="string", length=22, nullable=false) */ protected $name = ''; /**** * @var Domain * * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY") * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE") */ protected $domain; } ``` ``` /**** * Class WebsGroup * * @ORM\Entity * @ORM\Table(name="profils_websgroups", * uniqueConstraints={@ORM\UniqueConstraint(name="websgroup_unique",columns={"name", "domain"})} * ) */ class WebsGroup { /**** * @var integer * * @ORM\Id * @ORM\GeneratedValue * @ORM\Column(type="integer", nullable=false) */ protected $id; /**** * @var string * * @ORM\Column(type="string", length=22, nullable=false) */ protected $name = ''; /**** * @var Domain * * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY") * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE") */ protected $domain; /**** * @var ArrayCollection * * @ORM\ManyToMany(targetEntity="Web", indexBy="id", fetch="EXTRA_LAZY") * @ORM\JoinTable(name="profils*websgroups*webs", * joinColumns={ * @ORM\JoinColumn(name="websgroup_id", referencedColumnName="id", onDelete="CASCADE"), * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE") * }, * inverseJoinColumns={ * @ORM\JoinColumn(name="web_id", referencedColumnName="id", onDelete="CASCADE"), * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE") * } * ) */ protected $webs; } ``` I've got a domain, some web sites per domain and websgroups which group web sites. I want to be sure in my database that a web group from a domain D can contain only web sites from the very same domain but when calling the console tool for creating my schema it raise : ``` [Doctrine\ORM\ORMException] Column name `domain` referenced for relation from Entity\WebsGroup towards Entity\Web does not exist. ``` It's because domain is already an association to an entity which and is not part of the primary key. I've quick fixed `getDefiningClass` from `Doctrine\ORM\Tools\SchemaTool` to make it work but i really don't know if it's the proper way : ``` private function getDefiningClass($class, $referencedColumnName) { $referencedFieldName = $class->getFieldName($referencedColumnName); if ($class->hasField($referencedFieldName)) { return array($class, $referencedFieldName); } else if (in_array($referencedColumnName, $class->getIdentifierColumnNames())) { // it seems to be an entity as foreign key foreach ($class->getIdentifierFieldNames() as $fieldName) { if ($class->hasAssociation($fieldName) && $class->getSingleAssociationJoinColumnName($fieldName) == $referencedColumnName) { return $this->getDefiningClass( $this->em->getClassMetadata($class->associationMappings[$fieldName]['targetEntity']), $class->getSingleAssociationReferencedJoinColumnName($fieldName) ); } } } else if (in_array($referencedColumnName, $class->getAssociationNames())) { return $this->getDefiningClass( $this->em->getClassMetadata($class->associationMappings[$referencedColumnName]['targetEntity']), $class->getSingleAssociationReferencedJoinColumnName($referencedColumnName) ); } return null; } ```
admin added the Bug label 2026-01-22 14:10:28 +01:00
admin closed this issue 2026-01-22 14:10:29 +01:00
admin commented 2026-01-22 14:10:30 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Apr 29, 2013):

Comment created by @FabioBatSilva:

[~jedi_bc] Except for some CS this fix seems good.

If you have time you can send as pull request

@doctrinebot commented on GitHub (Apr 29, 2013): Comment created by @FabioBatSilva: [~jedi_bc] Except for some CS this fix seems good. If you have time you can send as [pull request](https://github.com/doctrine/doctrine2/pulls)
admin commented 2026-01-22 14:10:30 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Apr 30, 2013):

Comment created by jedi_bc:

I've start making a PR and a test case but it is linked to http://www.doctrine-project.org/jira/browse/DDC-2413
I'm looking in making a proper fix to DDC-2413 first.

@doctrinebot commented on GitHub (Apr 30, 2013): Comment created by jedi_bc: I've start making a PR and a test case but it is linked to http://www.doctrine-project.org/jira/browse/[DDC-2413](http://www.doctrine-project.org/jira/browse/DDC-2413) I'm looking in making a proper fix to [DDC-2413](http://www.doctrine-project.org/jira/browse/DDC-2413) first.
admin commented 2026-01-22 14:10:30 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (May 1, 2013):

Comment created by @beberlei:

You cannot use a reference column that is not a primary key. Doctrine does not support this.

@doctrinebot commented on GitHub (May 1, 2013): Comment created by @beberlei: You cannot use a reference column that is not a primary key. Doctrine does not support this.
admin commented 2026-01-22 14:10:32 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (May 1, 2013):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (May 1, 2013): Issue was closed with resolution "Invalid"
admin commented 2026-01-22 14:10:32 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Sep 10, 2013):

Comment created by bavo:

I stumbled on this issue when experiencing a similar bug.
There is something seriously wrong with the referencedColumn in a ManyToMany relationship.
When you use a PK as 'id' and set your referenced column to 'id' everything is fine.
But when you use 'productId' as PK and reference it properly creation fails because "column 'id' doens't exists in table", which is very strange. After introducing a bogus column 'id' to the entity, but still referencing 'productId' a linking table is created but it has FK's to 'id' not to productId. When changing the referenced column to 'bogus' the creation also fails because: "column 'bogus' doesn't exists in table".

To me doctrine checks the the referencedColumn for existence but after that just creates everything assuming the default PK 'id'.

@doctrinebot commented on GitHub (Sep 10, 2013): Comment created by bavo: I stumbled on this issue when experiencing a similar bug. There is something seriously wrong with the referencedColumn in a ManyToMany relationship. When you use a PK as 'id' and set your referenced column to 'id' everything is fine. But when you use 'productId' as PK and reference it properly creation fails because "column 'id' doens't exists in table", which is very strange. After introducing a bogus column 'id' to the entity, but still referencing 'productId' a linking table is created but it has FK's to 'id' not to productId. When changing the referenced column to 'bogus' the creation also fails because: "column 'bogus' doesn't exists in table". To me doctrine checks the the referencedColumn for existence but after that just creates everything assuming the default PK 'id'.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#3036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?