DDC-2294: [GH-579] Unit tests: cleanup of outdated / unused / commented out code #2879

Open
opened 2026-01-22 14:06:27 +01:00 by admin · 0 comments
Owner

Originally created by @doctrinebot on GitHub (Feb 12, 2013).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/579

Message:

Many methods in unit tests were unused, in particular in mocks, where methods overriding in the past were not overriding anything anymore.

Some commented out code was referring to features that seem to have been removed years ago, so I removed it as well.

HydratorMockStatement::bindParam() was adding extra parameter that its parent did not define, and that were never used, so I removed them as well.

Originally created by @doctrinebot on GitHub (Feb 12, 2013). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of BenMorel: Url: https://github.com/doctrine/doctrine2/pull/579 Message: Many methods in unit tests were unused, in particular in mocks, where methods overriding in the past were not overriding anything anymore. Some commented out code was referring to features that seem to have been removed years ago, so I removed it as well. `HydratorMockStatement::bindParam()` was adding extra parameter that its parent did not define, and that were never used, so I removed them as well.
admin added the Bug label 2026-01-22 14:06:27 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2879