DDC-2271: [GH-564] Fix a wrong return type #2853

New Issue

admin · 2026-01-22T14:05:51+01:00

admin commented

2026-01-22 14:05:51 +01:00

Originally created by @doctrinebot on GitHub (Feb 3, 2013).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/564

Message:

BasicEntityPersister::executeInserts() is documented as:

@return array An array of any generated post-insert IDs. This will be an empty array
if the entity class does not use the IDENTITY generation strategy.

This PR fixes an empty return; that contradicted the documented return type.

Originally created by @doctrinebot on GitHub (Feb 3, 2013). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of BenMorel: Url: https://github.com/doctrine/doctrine2/pull/564 Message: `BasicEntityPersister::executeInserts()` is documented as: ``` @return array An array of any generated post-insert IDs. This will be an empty array if the entity class does not use the IDENTITY generation strategy. ``` This PR fixes an empty `return;` that contradicted the documented return type.

admin added the Bug label 2026-01-22 14:05:51 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2853