DDC-229: Changeset 6982 breakage #285

New Issue

admin · 2026-01-22T12:33:30+01:00

admin commented

2026-01-22 12:33:30 +01:00

Originally created by @doctrinebot on GitHub (Dec 27, 2009).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user romanb:

http://trac.doctrine-project.org/changeset/6982/

The new processDeferredExpressionsStack does not look good. It processes all expressions. Previously, each (sub)query had its own stack.

Now, when you do sth like this: "select u, (select max(o.id) from Other o) maxId from User u" you will trigger all validations at the end of the subquery. 'u' will be validated but is still undefined.

Please explain why the old behavior with one stack for each (sub)query was not preserved.

Also, things like

$method = '_validate' . $item['method'];

lead to very fragile (bad) code.

Originally created by @doctrinebot on GitHub (Dec 27, 2009). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user romanb: http://trac.doctrine-project.org/changeset/6982/ The new processDeferredExpressionsStack does not look good. It processes **all** expressions. Previously, each (sub)query had its own stack. Now, when you do sth like this: "select u, (select max(o.id) from Other o) maxId from User u" you will trigger all validations at the end of the subquery. 'u' will be validated but is still undefined. Please explain why the old behavior with one stack for each (sub)query was not preserved. Also, things like ``` $method = '_validate' . $item['method']; ``` lead to very fragile (bad) code.

admin added the Bug label 2026-01-22 12:33:30 +01:00

admin closed this issue

2026-01-22 12:33:30 +01:00

admin commented

2026-01-22 12:33:30 +01:00

@doctrinebot commented on GitHub (Dec 27, 2009):

Comment created by @guilhermeblanco:

Just a little mis-comprehension of the new way I've build expressions validations.
Resolving ticket.

@doctrinebot commented on GitHub (Dec 27, 2009): Comment created by @guilhermeblanco: Just a little mis-comprehension of the new way I've build expressions validations. Resolving ticket.

admin commented

2026-01-22 12:33:32 +01:00

@doctrinebot commented on GitHub (Dec 27, 2009):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Dec 27, 2009): Issue was closed with resolution "Fixed"

admin referenced this issue

2026-01-22 15:57:46 +01:00

[PR #285] [CLOSED] DDC-1373 specific mapping files #7969

admin referenced this issue

2026-01-22 15:57:47 +01:00

[PR #285] DDC-1373 specific mapping files #7972

Sign in to join this conversation.