DDC-2196: EntityManager can't be extended easily #2762

New Issue

admin · 2026-01-22T14:02:44+01:00

admin commented

2026-01-22 14:02:44 +01:00

Originally created by @doctrinebot on GitHub (Dec 14, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user mnapoli:

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new EntityManager($conn, $config, $conn->getEventManager());
}

The EntityManager::create method uses new on the EntityManager class instead of static.

This makes extending that class not practical because we have to rewrite (duplicate) EntityManager::create.

Code could be extendable with:

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new static($conn, $config, $conn->getEventManager());
}

Originally created by @doctrinebot on GitHub (Dec 14, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user mnapoli: ``` public static function create($conn, Configuration $config, EventManager $eventManager = null) { // ... return new EntityManager($conn, $config, $conn->getEventManager()); } ``` The `EntityManager::create` method uses new on the `EntityManager` class instead of `static`. This makes extending that class not practical because we have to rewrite (duplicate) `EntityManager::create`. Code could be extendable with: ``` public static function create($conn, Configuration $config, EventManager $eventManager = null) { // ... return new static($conn, $config, $conn->getEventManager()); } ```

admin added the Bug label 2026-01-22 14:02:44 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2762