doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-2159: [GH-519] Bug in UnitOfWork::executeDeletions when at least two entities have to b... #2718

New Issue
Closed
opened 2026-01-22 14:01:35 +01:00 by admin · 3 comments
admin commented 2026-01-22 14:01:35 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Nov 21, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of maryo:

Url: https://github.com/doctrine/doctrine2/pull/519

Message:

Bug in UnitOfWork::executeDeletions.

There is a foreach on line 1012 and dispatchEvent on line 1038.
When at least two entities have to be deleted and a listener listening to postRemove event is attached to them and there is also EntityManager::flush in that listener.

  • EntityManager::remove
  • EntityManager::remove
  • EntityManager::flush
    • UnitOfWork::commit
      • UnitOfWork::executeDeletions
        • BasicEntityPersister::delete // FOR THE FIRST REMOVED ENTITY
          ...
        • EventManager::dispatchEvent
          • PostRemoveListener::postRemove
            • EntityManager::flush
              • UnitOfWork::commit
                • UnitOfWork::executeDeletions
                  • BasicEntityPersister::delete // FOR THE SECOND REMOVED ENTITY
        • BasicEntityPersister::delete // FOR THE SECOND REMOVED ENTITY AGAIN because that foreach operates with array "copies" and that unset on line 1020 in UnitOfWork doesnt affact to the array copy
          • UnitOfWork::getEntityIdentifier // line 2735 - NOTICE, because the entity is already deleted from the array

Tests passed (those tests which are not skipped in my environment).

PHPUnit 3.7.9 by Sebastian Bergmann.

Configuration read from D:\Www\doctrine2\phpunit.xml.dist

.....................SSSSSS.................................. 61 / 1783 ( 3%)
............................................................. 122 / 1783 ( 6%)
......S.....SSSS............................................. 183 / 1783 ( 10%)
......................................................SS..... 244 / 1783 ( 13%)
............................................................. 305 / 1783 ( 17%)
............................................................. 366 / 1783 ( 20%)
......S...................................................... 427 / 1783 ( 23%)
............................................................. 488 / 1783 ( 27%)
....................SSSSSSSSSSSSS...........S................ 549 / 1783 ( 30%)
...........S...S...........S............................S.... 610 / 1783 ( 34%)
............................................................. 671 / 1783 ( 37%)
..............................................SS............. 732 / 1783 ( 41%)
....................S........................................ 793 / 1783 ( 44%)
............................................................. 854 / 1783 ( 47%)
............................................................. 915 / 1783 ( 51%)
............................................................. 976 / 1783 ( 54%)
...........................................................S. 1037 / 1783 ( 58%)
........................................S.................... 1098 / 1783 ( 61%)
............................................................. 1159 / 1783 ( 65%)
............................................................. 1220 / 1783 ( 68%)
............................................................. 1281 / 1783 ( 71%)
............................................................. 1342 / 1783 ( 75%)
............................................................. 1403 / 1783 ( 78%)
............................................................. 1464 / 1783 ( 82%)
............................................................. 1525 / 1783 ( 85%)
............................................................. 1586 / 1783 ( 88%)
............................................................. 1647 / 1783 ( 92%)
................S.............S.............................. 1708 / 1783 ( 95%)
.....................................................

Time: 14 seconds, Memory: 97.75Mb

OK, but incomplete or skipped tests!
Tests: 1761, Assertions: 5932, Skipped: 39.

Originally created by @doctrinebot on GitHub (Nov 21, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of maryo: Url: https://github.com/doctrine/doctrine2/pull/519 Message: Bug in UnitOfWork::executeDeletions. There is a foreach on line 1012 and dispatchEvent on line 1038. When at least two entities have to be deleted and a listener listening to postRemove event is attached to them and there is also EntityManager::flush in that listener. - EntityManager::remove - EntityManager::remove - EntityManager::flush - UnitOfWork::commit - UnitOfWork::executeDeletions - BasicEntityPersister::delete // FOR THE FIRST REMOVED ENTITY ... - EventManager::dispatchEvent - PostRemoveListener::postRemove - EntityManager::flush - UnitOfWork::commit - UnitOfWork::executeDeletions - BasicEntityPersister::delete // FOR THE SECOND REMOVED ENTITY - BasicEntityPersister::delete // FOR THE SECOND REMOVED ENTITY AGAIN because that foreach operates with array "copies" and that unset on line 1020 in UnitOfWork doesnt affact to the array copy - UnitOfWork::getEntityIdentifier // line 2735 - NOTICE, because the entity is already deleted from the array Tests passed (those tests which are not skipped in my environment). PHPUnit 3.7.9 by Sebastian Bergmann. Configuration read from D:\Www\doctrine2\phpunit.xml.dist .....................SSSSSS.................................. 61 / 1783 ( 3%) ............................................................. 122 / 1783 ( 6%) ......S.....SSSS............................................. 183 / 1783 ( 10%) ......................................................SS..... 244 / 1783 ( 13%) ............................................................. 305 / 1783 ( 17%) ............................................................. 366 / 1783 ( 20%) ......S...................................................... 427 / 1783 ( 23%) ............................................................. 488 / 1783 ( 27%) ....................SSSSSSSSSSSSS...........S................ 549 / 1783 ( 30%) ...........S...S...........S............................S.... 610 / 1783 ( 34%) ............................................................. 671 / 1783 ( 37%) ..............................................SS............. 732 / 1783 ( 41%) ....................S........................................ 793 / 1783 ( 44%) ............................................................. 854 / 1783 ( 47%) ............................................................. 915 / 1783 ( 51%) ............................................................. 976 / 1783 ( 54%) ...........................................................S. 1037 / 1783 ( 58%) ........................................S.................... 1098 / 1783 ( 61%) ............................................................. 1159 / 1783 ( 65%) ............................................................. 1220 / 1783 ( 68%) ............................................................. 1281 / 1783 ( 71%) ............................................................. 1342 / 1783 ( 75%) ............................................................. 1403 / 1783 ( 78%) ............................................................. 1464 / 1783 ( 82%) ............................................................. 1525 / 1783 ( 85%) ............................................................. 1586 / 1783 ( 88%) ............................................................. 1647 / 1783 ( 92%) ................S.............S.............................. 1708 / 1783 ( 95%) ..................................................... Time: 14 seconds, Memory: 97.75Mb OK, but incomplete or skipped tests! Tests: 1761, Assertions: 5932, Skipped: 39.
admin added the Bug label 2026-01-22 14:01:35 +01:00
admin closed this issue 2026-01-22 14:01:36 +01:00
admin commented 2026-01-22 14:01:36 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Nov 21, 2012):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (Nov 21, 2012): Issue was closed with resolution "Invalid"
admin commented 2026-01-22 14:01:37 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Nov 21, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-519] was closed
https://github.com/doctrine/doctrine2/pull/519

@doctrinebot commented on GitHub (Nov 21, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-519] was closed https://github.com/doctrine/doctrine2/pull/519
admin commented 2026-01-22 14:01:38 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jan 28, 2014):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-519] was closed:
https://github.com/doctrine/dbal/pull/519

@doctrinebot commented on GitHub (Jan 28, 2014): Comment created by @doctrinebot: A related Github Pull-Request [GH-519] was closed: https://github.com/doctrine/dbal/pull/519
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?