mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-23: Limit and offset in QueryBuilder #27
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Sep 29, 2009).
Originally assigned to: @guilhermeblanco on GitHub.
Jira issue originally created by user itoijala:
Currently (2.0 Alpha 1) QueryBuilder does not support limit or offset functionality. These were supported in Doctrine 1 and should be added. QueryBuilder's value is significantly lower without these features because simple pagination is not possible. Methods limit($limit) and offset($offset) should be added to QueryBuilder, like in Doctrine 1. Query already has support for limit and offset, so this should not be a large change.
@doctrinebot commented on GitHub (Sep 29, 2009):
Comment created by romanb:
You can set the limit/offset on the query when you're done building it.
LIMIT/OFFSET is no longer part of DQL.
We may consider adding forwarding methods to QueryBuilder, similar to setParameter() but only if there is some advantage to it. Is there?
@doctrinebot commented on GitHub (Oct 1, 2009):
Comment created by @guilhermeblanco:
Although it's currently possible to be done via Query retrieval, I think Ismo is correct and we should add 2 delegate methods to setFirstResult and setMaxResults.
That would make QueryBuilder more complete and easy to follow the workflow (Query <=> QueryBuilder).
I'm +1 to add it. If you agree, I can implement the patch and attach to next release.
@doctrinebot commented on GitHub (Oct 1, 2009):
Comment created by @guilhermeblanco:
I found this enhancement interesting and implemented this. I committed a patch to support it in trunk, so in next alpha it'll be available.
Changeset: http://trac.doctrine-project.org/changeset/6415
Cheers,
@doctrinebot commented on GitHub (Oct 1, 2009):
Issue was closed with resolution "Fixed"