DDC-2081: [GH-480] Change SqlWalker property visibility #2625

New Issue

admin · 2026-01-22T13:58:38+01:00

admin commented

2026-01-22 13:58:38 +01:00

Originally created by @doctrinebot on GitHub (Oct 15, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of djlambert:

Url: https://github.com/doctrine/doctrine2/pull/480

Message:

I'm working on a library to add support for spatial data types and functions to Doctrine. I'm trying to implement a custom AST walker which will return objects from DQL queries instead of scalar values. I've currently gotten this to work but the implementation feels a bit hack-ish:

https://github.com/djlambert/doctrine2-spatial/blob/master/lib/CrEOF/Spatial/ORM/Query/GeometryWalker.php

With the visibility on the SqlWalker class properties changed it allows for what I feel is a cleaner implementation:

https://github.com/djlambert/doctrine2-spatial/blob/sqlwalker-visibility/lib/CrEOF/Spatial/ORM/Query/GeometryWalker.php

I'm only using the $rsm, $scalarResultCounter, and $scalarResultAliasMap properties, but I changed all of them with the thought that someone else might find the others useful.

Originally created by @doctrinebot on GitHub (Oct 15, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of djlambert: Url: https://github.com/doctrine/doctrine2/pull/480 Message: I'm working on a library to add support for spatial data types and functions to Doctrine. I'm trying to implement a custom AST walker which will return objects from DQL queries instead of scalar values. I've currently gotten this to work but the implementation feels a bit hack-ish: https://github.com/djlambert/doctrine2-spatial/blob/master/lib/CrEOF/Spatial/ORM/Query/GeometryWalker.php With the visibility on the SqlWalker class properties changed it allows for what I feel is a cleaner implementation: https://github.com/djlambert/doctrine2-spatial/blob/sqlwalker-visibility/lib/CrEOF/Spatial/ORM/Query/GeometryWalker.php I'm only using the `$rsm`, `$scalarResultCounter`, and `$scalarResultAliasMap` properties, but I changed all of them with the thought that someone else might find the others useful.

admin added the Bug label 2026-01-22 13:58:38 +01:00

admin closed this issue

2026-01-22 13:58:38 +01:00

admin commented

2026-01-22 13:58:39 +01:00

@doctrinebot commented on GitHub (Oct 27, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-480] was closed
https://github.com/doctrine/doctrine2/pull/480

@doctrinebot commented on GitHub (Oct 27, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-480] was closed https://github.com/doctrine/doctrine2/pull/480

admin commented

2026-01-22 13:58:39 +01:00

@doctrinebot commented on GitHub (Oct 27, 2012):

Comment created by @FabioBatSilva:

Closed..
For more details : https://github.com/doctrine/doctrine2/pull/480

@doctrinebot commented on GitHub (Oct 27, 2012): Comment created by @FabioBatSilva: Closed.. For more details : https://github.com/doctrine/doctrine2/pull/480

admin commented

2026-01-22 13:58:40 +01:00

@doctrinebot commented on GitHub (Oct 27, 2012):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (Oct 27, 2012): Issue was closed with resolution "Invalid"

admin commented

2026-01-22 13:58:40 +01:00

@doctrinebot commented on GitHub (Dec 29, 2013):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-480] was closed:
https://github.com/doctrine/dbal/pull/480

@doctrinebot commented on GitHub (Dec 29, 2013): Comment created by @doctrinebot: A related Github Pull-Request [GH-480] was closed: https://github.com/doctrine/dbal/pull/480

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2625