DDC-2012: Inserting a new entity with a custom mapping type does not call convertToDatabaseValueSQL() when using InheritanceType("JOINED") #2538

New Issue

admin · 2026-01-22T13:56:11+01:00

admin commented

2026-01-22 13:56:11 +01:00

Originally created by @doctrinebot on GitHub (Sep 4, 2012).

Jira issue originally created by user darklow:

When using class type inheritance - @InheritanceType("JOINED") and inserting new entity with a custom mapping type, custom type method convertToDatabaseValueSQL() is never called.

Here is sample class mapping:

/****
 * @Table(name="item")
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="type_id", type="smallint")
 * @DiscriminatorMap({1 = "ItemPerson"})
 */
class Item {

    /****
     * @Column(name="tsv", type="tsvector", nullable=true)
     */
    protected $tsv;
}

/****
 * @Table(name="item_person")
 * @Entity
 */
class ItemPerson extends Item
{
}

I am using the same custom TsvectorType with simple entities and even Mapped Superclasses and it works perfectly, however on InheritanceType("JOINED") method convertToDatabaseValueSQL() is never called :/
Hope someone knows how to fix this.
Thank you.

Originally created by @doctrinebot on GitHub (Sep 4, 2012). Jira issue originally created by user darklow: When using class type inheritance - @InheritanceType("JOINED") and inserting new entity with a custom mapping type, custom type method convertToDatabaseValueSQL() is never called. Here is sample class mapping: ``` php /**** * @Table(name="item") * @Entity * @InheritanceType("JOINED") * @DiscriminatorColumn(name="type_id", type="smallint") * @DiscriminatorMap({1 = "ItemPerson"}) */ class Item { /**** * @Column(name="tsv", type="tsvector", nullable=true) */ protected $tsv; } /**** * @Table(name="item_person") * @Entity */ class ItemPerson extends Item { } ``` I am using the same custom TsvectorType with simple entities and even Mapped Superclasses and it works perfectly, however on InheritanceType("JOINED") method convertToDatabaseValueSQL() is never called :/ Hope someone knows how to fix this. Thank you.

admin added the Bug label 2026-01-22 13:56:11 +01:00

admin closed this issue

2026-01-22 13:56:11 +01:00

admin commented

2026-01-22 13:56:11 +01:00

@doctrinebot commented on GitHub (Sep 24, 2012):

Comment created by @FabioBatSilva:

Hi Kaspars,

I can't reproduce,
Could you change the added testcase and try to make it fails ?

Thanks

@doctrinebot commented on GitHub (Sep 24, 2012): Comment created by @FabioBatSilva: Hi Kaspars, I can't reproduce, Could you change the added testcase and try to make it fails ? Thanks

admin commented

2026-01-22 13:56:12 +01:00

@doctrinebot commented on GitHub (Sep 26, 2012):

Comment created by darklow:

@Fabio thanks for looking into my problem
I attached test where you can detect the problem.

It was quite strange, all i did was changed column that uses custom type to array and some minimal convertToDatabaseValue and convertToDatabaseValueSQL logic and convertToDatabaseValueSQL was never called.

One more thing i noticed, this bug only appears on persist and not on merge.

Thanks

@doctrinebot commented on GitHub (Sep 26, 2012): Comment created by darklow: @Fabio thanks for looking into my problem I attached test where you can detect the problem. It was quite strange, all i did was changed column that uses custom type to array and some minimal convertToDatabaseValue and convertToDatabaseValueSQL logic and convertToDatabaseValueSQL was never called. One more thing i noticed, this bug only appears on persist and not on merge. Thanks

admin commented

2026-01-22 13:56:13 +01:00

@doctrinebot commented on GitHub (Sep 29, 2012):

Comment created by @FabioBatSilva:

Thanks Kaspars :)

But sorry, I dont get your use case.

Notice that convertToDatabaseValueSQL is called just when using queries to find a object by a especific columns which is your mapping type.

http://docs.doctrine-project.org/en/2.1/cookbook/advanced-field-value-conversion-using-custom-mapping-types.html#the-mapping-type

@doctrinebot commented on GitHub (Sep 29, 2012): Comment created by @FabioBatSilva: Thanks Kaspars :) But sorry, I dont get your use case. Notice that convertToDatabaseValueSQL is called just when using queries to find a object by a especific columns which is your mapping type. http://docs.doctrine-project.org/en/2.1/cookbook/advanced-field-value-conversion-using-custom-mapping-types.html#the-mapping-type

admin commented

2026-01-22 13:56:13 +01:00

@doctrinebot commented on GitHub (Sep 29, 2012):

Comment created by darklow:

I am using PostgreSQL tsvector data type for full text search.

Here is my tsvector custom data type class:
https://gist.github.com/3129096

The only way to update this field in postgresql is to use postgresql function to_tsvector('some text').
And everything works fine, if i persist simple entity, this method transforms insert query as needed:

public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform)
{
    return sprintf('to_tsvector(%s)', $sqlExpr);
}

But when i use inheritance, then by some reason convertToDatabaseValueSQL method is not called and tsv field is updated with simple text as returned by convertToDatabaseValue() method.
I modified the Ticket Test so that you can see exact moment of when it is not called, which is exactly my problem.

Here is the result after persisting (for persist it failed)

$person = new ItemPerson();
$person->setName('some words for test');
$em->persist($person);
$em->flush();

DB Result:
Name                | Tsv
--------------------|------------------------------------
some words for test | 'for' 'some' 'test' 'words'

Here is the result after second time update (now by tsv format you can see it worked):

$person->setName('some more words for test');
$em->flush();

DB Result:
Name                | Tsv
--------------------|------------------------------------
some words for test | 'test':5 'word':3

@doctrinebot commented on GitHub (Sep 29, 2012): Comment created by darklow: I am using PostgreSQL tsvector data type for full text search. Here is my tsvector custom data type class: https://gist.github.com/3129096 The only way to update this field in postgresql is to use postgresql function to_tsvector('some text'). And everything works fine, if i persist simple entity, this method transforms insert query as needed: ``` public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform) { return sprintf('to_tsvector(%s)', $sqlExpr); } ``` But when i use inheritance, then by some reason convertToDatabaseValueSQL method is not called and tsv field is updated with simple text as returned by convertToDatabaseValue() method. I modified the Ticket Test so that you can see exact moment of when it is not called, which is exactly my problem. Here is the result after persisting (for persist it failed) ``` $person = new ItemPerson(); $person->setName('some words for test'); $em->persist($person); $em->flush(); DB Result: Name | Tsv --------------------|------------------------------------ some words for test | 'for' 'some' 'test' 'words' ``` Here is the result after second time update (now by tsv format you can see it worked): ``` $person->setName('some more words for test'); $em->flush(); DB Result: Name | Tsv --------------------|------------------------------------ some words for test | 'test':5 'word':3 ```

admin commented

2026-01-22 13:56:13 +01:00

@doctrinebot commented on GitHub (Sep 30, 2012):

Comment created by @FabioBatSilva:

Thanks Kaspars

Now i saw the problem

Writing a patch ...

@doctrinebot commented on GitHub (Sep 30, 2012): Comment created by @FabioBatSilva: Thanks Kaspars Now i saw the problem Writing a patch ...

admin commented

2026-01-22 13:56:14 +01:00

@doctrinebot commented on GitHub (Oct 3, 2012):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Oct 3, 2012): Issue was closed with resolution "Fixed"

admin commented

2026-01-22 13:56:14 +01:00

@doctrinebot commented on GitHub (Oct 3, 2012):

Comment created by darklow:

Just tested fixed version and everything works perfectly now.
Thank you!

@doctrinebot commented on GitHub (Oct 3, 2012): Comment created by darklow: Just tested fixed version and everything works perfectly now. Thank you!

admin commented

2026-01-22 13:56:15 +01:00

@doctrinebot commented on GitHub (Oct 3, 2012):

Comment created by @FabioBatSilva:

Fixed by : 91caff1d89

@doctrinebot commented on GitHub (Oct 3, 2012): Comment created by @FabioBatSilva: Fixed by : https://github.com/doctrine/doctrine2/commit/91caff1d8965c20b72d5fdd04ffadf3ab063c1ba

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2538