DDC-1973: [GH-420] Cascade dependent identities to associations #2489

New Issue

admin · 2026-01-22T13:55:03+01:00

admin commented

2026-01-22 13:55:03 +01:00

Originally created by @doctrinebot on GitHub (Aug 8, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of djlambert:

Url: https://github.com/doctrine/doctrine2/pull/420

Message:

Currently when an entity in a one-to-one association gets its identity from another entity it requires calling the setter for the associated entity from the setter in the identity source entity setter or passing the identity source entity to the associated entity's constructer, something similar to this:

<?php
/****
 * @Entity
 */
class User
{
    /*** @Id @Column(type="integer") @GeneratedValue **/
    private $id;

    /*** @OneToOne(targetEntity="Address", mappedBy="user", cascade={"persist"}) **/
    private $address;

    public setAddress(Address $address)
    {
        $this->address = $address;
        $address->setUser($this); // Calling setter in associated entity
    }
}

/****
 * @Entity
 */
class Address
{
    /*** @Id @OneToOne(targetEntity="User", inversedBy="address") **/
    private $user;

    **construct(User $user)
    {
        $this->user = $user; // Passing identity source to constructor
    }

    public setUser(User $user)
    {
        $this->user = $user;
    }
}

$user = new User();
$em->persist($user);
$em->flush();

$address = new Address($user); // If using constructor
$user->setAddress($address);
// OR
$user->setAddress(new Address()); // If using setter

$em->flush();

This PR adds checks for associations with cascade persist that have dependent identities which are empty, and sets the field in the associated entity to the identity source entity. Granted it's not complicated to do as the previous example, but this allows for simpler code. It also seems a logical assumption that when the association is cascade persist this should happen automatically:

<?php
/****
 * @Entity
 */
class User
{
    /*** @Id @Column(type="integer") @GeneratedValue **/
    private $id;

    /*** @OneToOne(targetEntity="Address", mappedBy="user", cascade={"persist"}) **/
    private $address;

    public setAddress(Address $address)
    {
        $this->address = $address;
    }
}

/****
 * @Entity
 */
class Address
{
    /*** @Id @OneToOne(targetEntity="User", inversedBy="address") **/
    private $user;

    // This could be removed if not needed
    public setUser(User $user)
    {
        $this->user = $user;
    }
}

$user = new User();
$em->persist($user);
$em->flush();

$user->setAddress(new Address());

$em->flush();

Now only if it wasn't so wordy to explain :)

Originally created by @doctrinebot on GitHub (Aug 8, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of djlambert: Url: https://github.com/doctrine/doctrine2/pull/420 Message: Currently when an entity in a one-to-one association gets its identity from another entity it requires calling the setter for the associated entity from the setter in the identity source entity setter or passing the identity source entity to the associated entity's constructer, something similar to this: ``` php <?php /**** * @Entity */ class User { /*** @Id @Column(type="integer") @GeneratedValue **/ private $id; /*** @OneToOne(targetEntity="Address", mappedBy="user", cascade={"persist"}) **/ private $address; public setAddress(Address $address) { $this->address = $address; $address->setUser($this); // Calling setter in associated entity } } /**** * @Entity */ class Address { /*** @Id @OneToOne(targetEntity="User", inversedBy="address") **/ private $user; **construct(User $user) { $this->user = $user; // Passing identity source to constructor } public setUser(User $user) { $this->user = $user; } } $user = new User(); $em->persist($user); $em->flush(); $address = new Address($user); // If using constructor $user->setAddress($address); // OR $user->setAddress(new Address()); // If using setter $em->flush(); ``` This PR adds checks for associations with cascade persist that have dependent identities which are empty, and sets the field in the associated entity to the identity source entity. Granted it's not complicated to do as the previous example, but this allows for simpler code. It also seems a logical assumption that when the association is cascade persist this should happen automatically: ``` php <?php /**** * @Entity */ class User { /*** @Id @Column(type="integer") @GeneratedValue **/ private $id; /*** @OneToOne(targetEntity="Address", mappedBy="user", cascade={"persist"}) **/ private $address; public setAddress(Address $address) { $this->address = $address; } } /**** * @Entity */ class Address { /*** @Id @OneToOne(targetEntity="User", inversedBy="address") **/ private $user; // This could be removed if not needed public setUser(User $user) { $this->user = $user; } } $user = new User(); $em->persist($user); $em->flush(); $user->setAddress(new Address()); $em->flush(); ``` Now only if it wasn't so wordy to explain :)

admin added the Bug label 2026-01-22 13:55:03 +01:00

admin closed this issue

2026-01-22 13:55:03 +01:00

admin commented

2026-01-22 13:55:04 +01:00

@doctrinebot commented on GitHub (Aug 8, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-420] was closed
https://github.com/doctrine/doctrine2/pull/420

@doctrinebot commented on GitHub (Aug 8, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-420] was closed https://github.com/doctrine/doctrine2/pull/420

admin commented

2026-01-22 13:55:05 +01:00

@doctrinebot commented on GitHub (Aug 14, 2012):

Comment created by @asm89:

User closed the PR as it was not valid.

@doctrinebot commented on GitHub (Aug 14, 2012): Comment created by @asm89: User closed the PR as it was not valid.

admin commented

2026-01-22 13:55:05 +01:00

@doctrinebot commented on GitHub (Aug 14, 2012):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (Aug 14, 2012): Issue was closed with resolution "Invalid"

admin commented

2026-01-22 13:55:05 +01:00

@doctrinebot commented on GitHub (Dec 20, 2013):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-420] was closed:
https://github.com/doctrine/dbal/pull/420

@doctrinebot commented on GitHub (Dec 20, 2013): Comment created by @doctrinebot: A related Github Pull-Request [GH-420] was closed: https://github.com/doctrine/dbal/pull/420

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2489