mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-1893: Doctrine\ORM\Mapping\Driver\AnnotationDriver::create() not updated for new annotation readers #2386
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Jun 26, 2012).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user vasekpurchart:
After refactoring of annotation readers, there are new defaults and the current implementation calls undefined method, because Doctrine\Common\Annotations\AnnotationReader has been refactored too. The new way should be probably requiring Doctrine\Common\Annotations\Reader interface as $reader parameter and if not present constructing the default as in Doctrine\ORM\Configuration::create :
AnnotationRegistry::registerFile(DIR . '/Mapping/Driver/DoctrineAnnotations.php');
$reader = new \Doctrine\Common\Annotations\SimpleAnnotationReader();
$reader->addNamespace('Doctrine\ORM\Mapping');
$reader = new \Doctrine\Common\Annotations\CachedReader($reader, new ArrayCache());
@doctrinebot commented on GitHub (Jul 6, 2012):
Comment created by @ocramius:
Looking into this today
@doctrinebot commented on GitHub (Jul 6, 2012):
Comment created by @beberlei:
$config->newDefaultAnnotationDriver should have a flag for picking the simple or the "ORM" prefixed reader
@doctrinebot commented on GitHub (Jul 8, 2012):
Comment created by @ocramius:
Handled in DDC-1915 (https://github.com/doctrine/doctrine2/pull/396)
@doctrinebot commented on GitHub (Jul 8, 2012):
Issue was closed with resolution "Fixed"