DDC-1877: [GH-376] De-deprecate transaction handling methods #2372

Closed
opened 2026-01-22 13:50:47 +01:00 by admin · 2 comments
Owner

Originally created by @doctrinebot on GitHub (Jun 16, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/doctrine2/pull/376

Message:

As discussed with @beberlei over IRC, deprecating transaction handling methods make the API cleaner but testing of Entity Manager dependent components much messier. Also suggesting to use $em->getConnection()->beginTransaction() feels like a violation of the law of demeter.

Therefore this pull request would remove the deprecation warnings from EntityManager::beginTransaction(), EntityManager::commit(), EntityManager::rollback().

Originally created by @doctrinebot on GitHub (Jun 16, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of lstrojny: Url: https://github.com/doctrine/doctrine2/pull/376 Message: As discussed with @beberlei over IRC, deprecating transaction handling methods make the API cleaner but testing of Entity Manager dependent components much messier. Also suggesting to use `$em->getConnection()->beginTransaction()` feels like a violation of the law of demeter. Therefore this pull request would remove the deprecation warnings from `EntityManager::beginTransaction()`, `EntityManager::commit()`, `EntityManager::rollback()`.
admin added the Bug label 2026-01-22 13:50:47 +01:00
admin closed this issue 2026-01-22 13:50:49 +01:00
Author
Owner

@doctrinebot commented on GitHub (Jul 4, 2012):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Jul 4, 2012): Issue was closed with resolution "Fixed"
Author
Owner

@doctrinebot commented on GitHub (Oct 7, 2013):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-376] was closed:
https://github.com/doctrine/dbal/pull/376

@doctrinebot commented on GitHub (Oct 7, 2013): Comment created by @doctrinebot: A related Github Pull-Request [GH-376] was closed: https://github.com/doctrine/dbal/pull/376
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2372