DDC-1812: Modify ResultSetMapping#addMetaResult function definition #2280

New Issue

2026-01-22T13:47:16+01:00

admin commented

2026-01-22 13:47:16 +01:00

Originally created by @doctrinebot on GitHub (May 6, 2012).

Originally assigned to: @Ocramius on GitHub.

Jira issue originally created by user rivaros:

Give correct names to arguments

    public function addMetaResult($alias, $columnName, $fieldName, $isIdentifierColumn = false)
    {

$alias - should be $tableAlias
$columnName should be $columnAlias
$fieldName should be $columnName

Here are some exmple calls from code:
AbstractEntityInheritancePersister.php
79: $this->_rsm->addMetaResult('r', $columnAlias, $joinColumnName);
SqlWalker.php

$this->_rsm->addMetaResult($dqlAlias, $columnAlias, $discrColumn['fieldName']); 
$this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn, (isset($assoc['id']) && $assoc['id'] === true)); 
$this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn);

Originally created by @doctrinebot on GitHub (May 6, 2012). Originally assigned to: @Ocramius on GitHub. Jira issue originally created by user rivaros: Give correct names to arguments ``` public function addMetaResult($alias, $columnName, $fieldName, $isIdentifierColumn = false) { ``` `$alias` - should be `$tableAlias` `$columnName` should be `$columnAlias` `$fieldName` should be `$columnName` Here are some exmple calls from code: `AbstractEntityInheritancePersister.php` 79: `$this->_rsm->addMetaResult('r', $columnAlias, $joinColumnName);` `SqlWalker.php` ```php $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $discrColumn['fieldName']); $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn, (isset($assoc['id']) && $assoc['id'] === true)); $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn); ```

admin added the Improvement Duplicate labels 2026-01-22 13:47:16 +01:00

admin closed this issue

2026-01-22 13:47:17 +01:00

admin commented

2026-01-22 13:47:20 +01:00

@malukenho commented on GitHub (Jan 5, 2017):

@Ocramius @lcobucci can be closed as invalid

@malukenho commented on GitHub (Jan 5, 2017): @Ocramius @lcobucci can be closed as invalid

admin commented

2026-01-22 13:47:20 +01:00

@Ocramius commented on GitHub (Jan 5, 2017):

@malukenho I think that a parameter rename makes sense here...

@Ocramius commented on GitHub (Jan 5, 2017): @malukenho I think that a parameter rename makes sense here...

admin commented

2026-01-22 13:47:20 +01:00

@malukenho commented on GitHub (Jan 5, 2017):

@Ocramius the parameters was already renamed. Look https://github.com/doctrine/doctrine2/blob/843966ac50d216b7c55e9f5fde7441fbf25dad57/lib/Doctrine/ORM/Persisters/Entity/AbstractEntityInheritancePersister.php#L90

@malukenho commented on GitHub (Jan 5, 2017): @Ocramius the parameters was already renamed. Look https://github.com/doctrine/doctrine2/blob/843966ac50d216b7c55e9f5fde7441fbf25dad57/lib/Doctrine/ORM/Persisters/Entity/AbstractEntityInheritancePersister.php#L90

admin commented

2026-01-22 13:47:21 +01:00

@Ocramius commented on GitHub (Jan 5, 2017):

Indeed, thanks!

@Ocramius commented on GitHub (Jan 5, 2017): Indeed, thanks!

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2280