mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
DDC-1805: [GH-343] Lets make correct data structure #2273
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (May 1, 2012).
Originally assigned to: @beberlei on GitHub.
Jira issue originally created by user @beberlei:
This issue is created automatically through a Github pull request on behalf of rivaros:
Url: https://github.com/doctrine/doctrine2/pull/343
Message:
Dear all,
As you know Doctine2 supports explicit quoting of identifiers.
This is extremely useful for PostgreSQL where "TableName" and TableName(implicit lowercased) are 2 different things. That's why - please, do support explicit quoting with ` (back-ticks) in future.
Now a problem - you do not support quoting columns which are part of associations. Can you give me a reasonable answer why it should not be supported?
Now comes my first update - i think that keeping "quoted" property inside the fieldMapping array is globally wrong. "Quoted" is a property, related to a column, not field. For example, an association can consist of 2 joined columns, and 1 of them can be quoted (theoretically).
That's why a better choice to store "Quoted/Nonquoted" properties in ClassMetadata level. I made an array quotedColumns for this and rewrote the function getQuotedColumnName to use it.
If you have time for short dispute, I may have a solution to make explicit quoting supported in join columns.
See related thread here:
http://www.doctrine-project.org/jira/browse/DDC-142
Last comment was
"After some discussion support for quoting join column names and discriminator column names has been dropped for the sake of simplicity.
Quoting table names and regular column names will continue to be supported.
The docs have been updated accordingly."
I can argue on this - my solution is even more simple.
@doctrinebot commented on GitHub (May 4, 2012):
Comment created by @beberlei:
A related Github Pull-Request [GH-343] was closed
https://github.com/doctrine/doctrine2/pull/343
@doctrinebot commented on GitHub (May 4, 2012):
Issue was closed with resolution "Invalid"
@doctrinebot commented on GitHub (Dec 20, 2013):
Comment created by @doctrinebot:
A related Github Pull-Request [GH-343] was closed:
https://github.com/doctrine/dbal/pull/343