DDC-1739: [GH-314] [WIP] Doctrine\Common metadata drivers reuse #2187

Closed
opened 2026-01-22 13:43:41 +01:00 by admin · 10 comments
Owner

Originally created by @doctrinebot on GitHub (Mar 30, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/314

Message:

This PR is strictly related with https://github.com/doctrine/common/pull/98 and tests won't pass until the doctrine-common submodule points to a merged version of it (will do so later, so please don't merge now ).

Basically, I just stripped any code duplicate of what already available in dcom master under Doctrine\Common\Persistence\Mapping\Driver.

Tests are OK on my environment when using the new commons submodule.

(This is a cleanup for #263, where I sadly did pull from the remote branch after rebasing)

Tests are still failing.

Originally created by @doctrinebot on GitHub (Mar 30, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of Ocramius: Url: https://github.com/doctrine/doctrine2/pull/314 Message: This PR is strictly related with https://github.com/doctrine/common/pull/98 and tests won't pass until the doctrine-common submodule points to a merged version of it (will do so later, so **please don't merge now** ). Basically, I just stripped any code duplicate of what already available in dcom master under Doctrine\Common\Persistence\Mapping\Driver. Tests are OK on my environment when using the new commons submodule. (This is a cleanup for #263, where I sadly did pull from the remote branch after rebasing) Tests are still failing.
admin added the Improvement label 2026-01-22 13:43:41 +01:00
admin closed this issue 2026-01-22 13:43:42 +01:00
Author
Owner

@doctrinebot commented on GitHub (Mar 30, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Mar 30, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Mar 30, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Mar 30, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Mar 30, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Mar 30, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Mar 30, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Mar 30, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Apr 1, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Apr 1, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Apr 4, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Apr 4, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Apr 6, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Apr 6, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (Apr 7, 2012):

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
https://github.com/doctrine/doctrine2/pull/314

@doctrinebot commented on GitHub (Apr 7, 2012): Comment created by @beberlei: A related Github Pull-Request [GH-314] was synchronize https://github.com/doctrine/doctrine2/pull/314
Author
Owner

@doctrinebot commented on GitHub (May 19, 2014):

Comment created by @doctrinebot:

A related Github Pull-Request [GH-314] was closed:
https://github.com/doctrine/common/pull/314

@doctrinebot commented on GitHub (May 19, 2014): Comment created by @doctrinebot: A related Github Pull-Request [GH-314] was closed: https://github.com/doctrine/common/pull/314
Author
Owner

@malukenho commented on GitHub (Jan 5, 2017):

@Ocramius it was solved on dc1655b127

@malukenho commented on GitHub (Jan 5, 2017): @Ocramius it was solved on https://github.com/doctrine/common/commit/dc1655b127c830a144be6c8a1fb6825ad73baf69
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2187