doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

DDC-1460: Default nullable behavior when not explicitly defining joinColumns #1829

New Issue
Closed
opened 2026-01-22 13:27:23 +01:00 by admin · 2 comments
admin commented 2026-01-22 13:27:23 +01:00
Owner
Copy Link

Originally created by @doctrinebot on GitHub (Oct 29, 2011).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user @asm89:

Currently there is are no defaults set for 'nullable' on OneToOne and ManyToMany associations where joinColumns are not explicitly defined. I believe it should be nullable=true as a default in both cases.

I already added the OneToOne case in this commit (not merged yet, I had to check first):
a175f39b35

Should I also add the 'nullable' => true as default if there are no join columns specified on a ManyToMany association?

Originally created by @doctrinebot on GitHub (Oct 29, 2011). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user @asm89: Currently there is are no defaults set for 'nullable' on OneToOne and ManyToMany associations where joinColumns are not explicitly defined. I believe it should be nullable=true as a default in both cases. I already added the OneToOne case in this commit (not merged yet, I had to check first): https://github.com/asm89/doctrine2/commit/a175f39b3592af434b578853e916953bebeec910 Should I also add the 'nullable' => true as default if there are no join columns specified on a ManyToMany association?
admin closed this issue 2026-01-22 13:27:24 +01:00
admin commented 2026-01-22 13:27:28 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jan 16, 2012):

Comment created by @guilhermeblanco:

We already spoke about this and agreed this change is not good

@doctrinebot commented on GitHub (Jan 16, 2012): Comment created by @guilhermeblanco: We already spoke about this and agreed this change is not good
admin commented 2026-01-22 13:27:30 +01:00
Author
Owner
Copy Link

@doctrinebot commented on GitHub (Jan 16, 2012):

Issue was closed with resolution "Invalid"

@doctrinebot commented on GitHub (Jan 16, 2012): Issue was closed with resolution "Invalid"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#1829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?