DDC-146: Select where clause is broken with @InheritanceType("SINGLE_TABLE") #181

New Issue

2026-01-22T12:29:50+01:00

admin commented

2026-01-22 12:29:50 +01:00

Originally created by @doctrinebot on GitHub (Nov 13, 2009).

Jira issue originally created by user rickdt:

The "AND" is missing before the condition on the discriminator

In SqlWalker:1110 note the "termsSql" which is not defined anywhere.

public function walkWhereClause($whereClause)
    {
        $sql = ' WHERE ';
        $condExpr = $whereClause->conditionalExpression;

        $sql .= implode(
            ' OR ', array_map(array($this, 'walkConditionalTerm'), $condExpr->conditionalTerms)
        );

        $discrSql = $this->*generateDiscriminatorColumnConditionSql($this->*currentRootAlias);

        if ($discrSql) {
            if ($termsSql) $sql .= ' AND';

            $sql .= ' ' . $discrSql;
        }

        return $sql;
    }

Originally created by @doctrinebot on GitHub (Nov 13, 2009). Jira issue originally created by user rickdt: The "AND" is missing before the condition on the discriminator In SqlWalker:1110 note the "termsSql" which is not defined anywhere. ``` public function walkWhereClause($whereClause) { $sql = ' WHERE '; $condExpr = $whereClause->conditionalExpression; $sql .= implode( ' OR ', array_map(array($this, 'walkConditionalTerm'), $condExpr->conditionalTerms) ); $discrSql = $this->*generateDiscriminatorColumnConditionSql($this->*currentRootAlias); if ($discrSql) { if ($termsSql) $sql .= ' AND'; $sql .= ' ' . $discrSql; } return $sql; } ```

admin added the Bug label 2026-01-22 12:29:51 +01:00

admin closed this issue

2026-01-22 12:29:51 +01:00

admin commented

2026-01-22 12:29:52 +01:00

@doctrinebot commented on GitHub (Nov 13, 2009):

Comment created by romanb:

This has already been fixed in trunk earlier today. See DDC-141.

@doctrinebot commented on GitHub (Nov 13, 2009): Comment created by romanb: This has already been fixed in trunk earlier today. See [DDC-141](http://www.doctrine-project.org/jira/browse/DDC-141).

admin commented

2026-01-22 12:29:53 +01:00