DDC-1277: BasicEntityPersister::expandParameters() will check associations #1610

New Issue

Closed

opened 2026-01-22 13:19:50 +01:00 by admin · 4 comments

admin commented 2026-01-22 13:19:50 +01:00

Owner

Copy Link

Originally created by @doctrinebot on GitHub (Jul 14, 2011).

Originally assigned to: @guilhermeblanco on GitHub.

Jira issue originally created by user jasper@nerdsweide.nl:

When executing a EntityRepository::findBy() or EntityRepository::findOnyBy() with criteria that contain a field/value pair where the field is an association-name and the value is an array, some (for me) unexpected behavior occurs.

First an example to make my statement a bit more clear:
I have an entity User and Group where Group has many Users (User many-to-one Group).

When I call UserRepository->findBy( array( 'group' => 1 )), all goes well.
When I call UserRepository->findBy( array( 'group' => array( 1, 2, 3 ))), I get an notice and no results (Notice: Array to string conversion in /opt/local/www/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php on line 613)

I've tracked the "problem" down to the BasicEntityPersister:

BasicEntityPersister::*getSelectEntitiesSQL(), which uses BasicEntityPersister::_getSelectConditionSQL(), correctly creates a query containing something like WHERE t0.group*id IN ( ? ).
But BasicEntityPersister::expandParameters() doesn't implode the array to some string that can be bound to the query. This is because it doesn't take into account that the field could be an association.

I don't know if this is intended behavior, but I would think not. I've therefor altered the BasicEntityPersister::expandParameters() a bit:

private function expandParameters($criteria)
    {
        $params = $types = array();

        foreach ($criteria AS $field => $value) {
            if ($value === null) {
                continue; // skip null values.
            }

            $type = null;
            if (isset($this->_class->fieldMappings[$field])) {
                $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType();
            // BEGIN: Jasper N. Brouwer (14-07-2011)
            } else if (isset($this->_class->associationMappings[$field])) {
                if ($this->_class->associationMappings[$field]['isOwningSide']) {
                    $targetClass = $this->*em->getClassMetadata($this->*class->associationMappings[$field]['targetEntity']);
                    $targetField = $this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName'];
                    if (isset($targetClass->fieldMappings[$targetField])) {
                        $type = Type::getType($targetClass->fieldMappings[$targetField]['type'])->getBindingType();
                    }
                }
            // END: Jasper N. Brouwer (14-07-2011)
            }
            if (is_array($value)) {
                $type += Connection::ARRAY*PARAM*OFFSET;
            }

            $params[] = $value;
            $types[] = $type;
        }
        return array($params, $types);                                                                                  
    }

I hope this bit of code also clarifies what I'm trying to explain a bit more...

Originally created by @doctrinebot on GitHub (Jul 14, 2011). Originally assigned to: @guilhermeblanco on GitHub. Jira issue originally created by user jasper@nerdsweide.nl: When executing a `EntityRepository::findBy()` or `EntityRepository::findOnyBy()` with criteria that contain a field/value pair where the field is an association-name and the value is an array, some (for me) unexpected behavior occurs. First an example to make my statement a bit more clear: I have an entity `User` and `Group` where `Group` has many `Users` (`User` many-to-one `Group`). When I call `UserRepository->findBy( array( 'group' => 1 ))`, all goes well. When I call `UserRepository->findBy( array( 'group' => array( 1, 2, 3 )))`, I get an notice and no results (Notice: Array to string conversion in /opt/local/www/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php on line 613) I've tracked the "problem" down to the `BasicEntityPersister`: `BasicEntityPersister::*getSelectEntitiesSQL()`, which uses `BasicEntityPersister::_getSelectConditionSQL()`, correctly creates a query containing something like `WHERE t0.group*id IN ( ? )`. But `BasicEntityPersister::expandParameters()` doesn't implode the array to some string that can be bound to the query. This is because it doesn't take into account that the field could be an association. I don't know if this is intended behavior, but I would think not. I've therefor altered the `BasicEntityPersister::expandParameters()` a bit: ``` none private function expandParameters($criteria) { $params = $types = array(); foreach ($criteria AS $field => $value) { if ($value === null) { continue; // skip null values. } $type = null; if (isset($this->_class->fieldMappings[$field])) { $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType(); // BEGIN: Jasper N. Brouwer (14-07-2011) } else if (isset($this->_class->associationMappings[$field])) { if ($this->_class->associationMappings[$field]['isOwningSide']) { $targetClass = $this->*em->getClassMetadata($this->*class->associationMappings[$field]['targetEntity']); $targetField = $this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName']; if (isset($targetClass->fieldMappings[$targetField])) { $type = Type::getType($targetClass->fieldMappings[$targetField]['type'])->getBindingType(); } } // END: Jasper N. Brouwer (14-07-2011) } if (is_array($value)) { $type += Connection::ARRAY*PARAM*OFFSET; } $params[] = $value; $types[] = $type; } return array($params, $types); } ``` I hope this bit of code also clarifies what I'm trying to explain a bit more...

admin added the Improvement label 2026-01-22 13:19:50 +01:00

admin closed this issue 2026-01-22 13:19:51 +01:00

admin commented 2026-01-22 13:19:53 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Aug 11, 2011):

Comment created by jasper@nerdsweide.nl:

I found an error in my fix :(

$this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName']; refers to a column-name, not a field-name. I made a new patch:

private function expandParameters($criteria)                                                                            
{
    $params = $types = array();

    foreach ($criteria AS $field => $value) {
        if ($value === null) {
            continue; // skip null values.
        }

        $type = null;
        if (isset($this->_class->fieldMappings[$field])) {
            $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType();
        // BEGIN: Jasper N. Brouwer (11-08-2011)
        } else if (isset($this->_class->associationMappings[$field])) {
            if ($this->_class->associationMappings[$field]['isOwningSide']) {
                $targetClass = $this->*em->getClassMetadata($this->*class->associationMappings[$field]['targetEntity']);
                $targetColumn = $this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName'];
                if (isset($targetClass->fieldNames[$targetColumn])) {
                    $type = Type::getType($targetClass->fieldMappings[$targetClass->fieldNames[$targetColumn]]['type'])->getBindingType();
                }
            }
        // END: Jasper N. Brouwer (11-08-2011)
        }
        if (is_array($value)) {
            $type += Connection::ARRAY*PARAM*OFFSET;
        }

        $params[] = $value;
        $types[] = $type;
    }
    return array($params, $types);
}

I'll attach a new diff to.

@doctrinebot commented on GitHub (Aug 11, 2011): Comment created by jasper@nerdsweide.nl: I found an error in my fix :( `$this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName'];` refers to a column-name, not a field-name. I made a new patch: ``` private function expandParameters($criteria) { $params = $types = array(); foreach ($criteria AS $field => $value) { if ($value === null) { continue; // skip null values. } $type = null; if (isset($this->_class->fieldMappings[$field])) { $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType(); // BEGIN: Jasper N. Brouwer (11-08-2011) } else if (isset($this->_class->associationMappings[$field])) { if ($this->_class->associationMappings[$field]['isOwningSide']) { $targetClass = $this->*em->getClassMetadata($this->*class->associationMappings[$field]['targetEntity']); $targetColumn = $this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName']; if (isset($targetClass->fieldNames[$targetColumn])) { $type = Type::getType($targetClass->fieldMappings[$targetClass->fieldNames[$targetColumn]]['type'])->getBindingType(); } } // END: Jasper N. Brouwer (11-08-2011) } if (is_array($value)) { $type += Connection::ARRAY*PARAM*OFFSET; } $params[] = $value; $types[] = $type; } return array($params, $types); } ``` I'll attach a new diff to.

admin commented 2026-01-22 13:19:53 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Aug 14, 2011):

Comment created by @guilhermeblanco:

Hi,

Thanks a lot to report this issue and attempt to fix it.
I extracted parts of your patch to resolve this issue, thanks again for investing your time on this.

This issue is not fixed on trunk by commit 63a2f02f4d

Cheers,

@doctrinebot commented on GitHub (Aug 14, 2011): Comment created by @guilhermeblanco: Hi, Thanks a lot to report this issue and attempt to fix it. I extracted parts of your patch to resolve this issue, thanks again for investing your time on this. This issue is not fixed on trunk by commit https://github.com/doctrine/doctrine2/commit/63a2f02f4ddea1ab9191b0e4acfd1d790d2247c7 Cheers,

admin commented 2026-01-22 13:19:53 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Aug 14, 2011):

Issue was closed with resolution "Fixed"

@doctrinebot commented on GitHub (Aug 14, 2011): Issue was closed with resolution "Fixed"

admin commented 2026-01-22 13:19:55 +01:00

Author

Owner

Copy Link

@doctrinebot commented on GitHub (Dec 13, 2015):

Imported 2 attachments from Jira into https://gist.github.com/1c9ab72dd9bcaed57847

• 11029_BasicEntityPersister.php.diff
• 11047_BasicEntityPersister.php-fixed.diff

@doctrinebot commented on GitHub (Dec 13, 2015): Imported 2 attachments from Jira into https://gist.github.com/1c9ab72dd9bcaed57847 - [11029_BasicEntityPersister.php.diff](https://gist.github.com/1c9ab72dd9bcaed57847#file-11029_BasicEntityPersister-php-diff) - [11047_BasicEntityPersister.php-fixed.diff](https://gist.github.com/1c9ab72dd9bcaed57847#file-11047_BasicEntityPersister-php-fixed-diff)

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label Improvement

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#1610