[PR #12342] [MERGED] Add Override attribute where applicable #13714

New Issue

Closed

opened 2026-01-22 16:18:15 +01:00 by admin · 0 comments

admin commented 2026-01-22 16:18:15 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/12342
Author: @greg0ire
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @greg0ire

Base: 4.0.x ← Head: override

---

📝 Commits (1)

• 59f7f67 Add Override attribute where applicable

📊 Changes

209 files changed (+846 additions, -0 deletions)

View changed files

📝 phpstan.neon (+1 -0)
📝 src/Cache/DefaultCache.php (+15 -0)
📝 src/Cache/DefaultCacheFactory.php (+9 -0)
📝 src/Cache/DefaultCollectionHydrator.php (+3 -0)
📝 src/Cache/DefaultEntityHydrator.php (+3 -0)
📝 src/Cache/DefaultQueryCache.php (+5 -0)
📝 src/Cache/Logging/CacheLoggerChain.php (+10 -0)
📝 src/Cache/Logging/StatisticsCacheLogger.php (+10 -0)
📝 src/Cache/Persister/Collection/AbstractCollectionPersister.php (+12 -0)
📝 src/Cache/Persister/Collection/NonStrictReadWriteCachedCollectionPersister.php (+5 -0)
📝 src/Cache/Persister/Collection/ReadOnlyCachedCollectionPersister.php (+2 -0)
📝 src/Cache/Persister/Collection/ReadWriteCachedCollectionPersister.php (+5 -0)
📝 src/Cache/Persister/Entity/AbstractEntityPersister.php (+29 -0)
📝 src/Cache/Persister/Entity/NonStrictReadWriteCachedEntityPersister.php (+5 -0)
📝 src/Cache/Persister/Entity/ReadOnlyCachedEntityPersister.php (+2 -0)
📝 src/Cache/Persister/Entity/ReadWriteCachedEntityPersister.php (+5 -0)
📝 src/Cache/Region/DefaultRegion.php (+8 -0)
📝 src/Cache/Region/FileLockRegion.php (+10 -0)
📝 src/Cache/Region/UpdateTimestampCache.php (+2 -0)
📝 src/Cache/TimestampQueryCacheValidator.php (+3 -0)

...and 80 more files

📄 Description

Note: many @inheritDoc annotations have become redundant because of this, but let us wait on https://github.com/slevomat/coding-standard/issues/1824 before attempting to address that.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/12342 **Author:** [@greg0ire](https://github.com/greg0ire) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@greg0ire](https://github.com/greg0ire) **Base:** `4.0.x` ← **Head:** `override` --- ### 📝 Commits (1) - [`59f7f67`](https://github.com/doctrine/orm/commit/59f7f6793d5d20968098a7bce683bc265701cb03) Add Override attribute where applicable ### 📊 Changes **209 files changed** (+846 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `phpstan.neon` (+1 -0) 📝 `src/Cache/DefaultCache.php` (+15 -0) 📝 `src/Cache/DefaultCacheFactory.php` (+9 -0) 📝 `src/Cache/DefaultCollectionHydrator.php` (+3 -0) 📝 `src/Cache/DefaultEntityHydrator.php` (+3 -0) 📝 `src/Cache/DefaultQueryCache.php` (+5 -0) 📝 `src/Cache/Logging/CacheLoggerChain.php` (+10 -0) 📝 `src/Cache/Logging/StatisticsCacheLogger.php` (+10 -0) 📝 `src/Cache/Persister/Collection/AbstractCollectionPersister.php` (+12 -0) 📝 `src/Cache/Persister/Collection/NonStrictReadWriteCachedCollectionPersister.php` (+5 -0) 📝 `src/Cache/Persister/Collection/ReadOnlyCachedCollectionPersister.php` (+2 -0) 📝 `src/Cache/Persister/Collection/ReadWriteCachedCollectionPersister.php` (+5 -0) 📝 `src/Cache/Persister/Entity/AbstractEntityPersister.php` (+29 -0) 📝 `src/Cache/Persister/Entity/NonStrictReadWriteCachedEntityPersister.php` (+5 -0) 📝 `src/Cache/Persister/Entity/ReadOnlyCachedEntityPersister.php` (+2 -0) 📝 `src/Cache/Persister/Entity/ReadWriteCachedEntityPersister.php` (+5 -0) 📝 `src/Cache/Region/DefaultRegion.php` (+8 -0) 📝 `src/Cache/Region/FileLockRegion.php` (+10 -0) 📝 `src/Cache/Region/UpdateTimestampCache.php` (+2 -0) 📝 `src/Cache/TimestampQueryCacheValidator.php` (+3 -0) _...and 80 more files_ </details> ### 📄 Description Note: many `@inheritDoc` annotations have become redundant because of this, but let us wait on https://github.com/slevomat/coding-standard/issues/1824 before attempting to address that. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

admin added the pull-request label 2026-01-22 16:18:15 +01:00

admin closed this issue 2026-01-22 16:18:16 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#13714