doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #12232] [MERGED] SQLFilter: replace internal array shape with class #13604

New Issue
Closed
opened 2026-01-22 16:17:45 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:17:45 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/12232
Author: @derrabus
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @derrabus

Base: 3.6.x ← Head: improvement/sql-filter-array-shape

📝 Commits (1)

  • b94211c SQLFilter: replace internal array shape with class

📊 Changes

5 files changed (+47 additions, -22 deletions)

View changed files

📝 phpstan-baseline.neon (+1 -7)
📝 phpstan.neon (+4 -0)
➕ src/Query/Filter/Parameter.php (+20 -0)
📝 src/Query/Filter/SQLFilter.php (+19 -12)
📝 src/Query/ParameterTypeInferer.php (+3 -3)

📄 Description

This is a small step towards better type coverage. I'm replacing the array shape we've been using inside the SQLFilter class with a class.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/12232 **Author:** [@derrabus](https://github.com/derrabus) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@derrabus](https://github.com/derrabus) **Base:** `3.6.x` ← **Head:** `improvement/sql-filter-array-shape` --- ### 📝 Commits (1) - [`b94211c`](https://github.com/doctrine/orm/commit/b94211c46ad7adec3819fefaf23b9650b926dcd7) SQLFilter: replace internal array shape with class ### 📊 Changes **5 files changed** (+47 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `phpstan-baseline.neon` (+1 -7) 📝 `phpstan.neon` (+4 -0) ➕ `src/Query/Filter/Parameter.php` (+20 -0) 📝 `src/Query/Filter/SQLFilter.php` (+19 -12) 📝 `src/Query/ParameterTypeInferer.php` (+3 -3) </details> ### 📄 Description This is a small step towards better type coverage. I'm replacing the array shape we've been using inside the `SQLFilter` class with a class. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:17:45 +01:00
admin closed this issue 2026-01-22 16:17:45 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#13604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?