doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #12222] Add ORDER BY clause to SELECT query #13595

New Issue
Closed
opened 2026-01-22 16:17:42 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:17:42 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/12222

State: closed
Merged: Yes

The order of results is not guaranteed unless we do so, and the test can fail in some cases:

There was 1 failure:

1) Doctrine\Tests\ORM\Functional\QueryTest::testToIterableWithMixedResultArbitraryJoinsScalars
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Doctrine 2'
+'lala 2'

/home/runner/work/orm/orm/tests/Tests/ORM/Functional/QueryTest.php:481

Spotted in https://github.com/doctrine/orm/actions/runs/18431080849/job/52518538835?pr=12221

**Original Pull Request:** https://github.com/doctrine/orm/pull/12222 **State:** closed **Merged:** Yes --- The order of results is not guaranteed unless we do so, and the test can fail in some cases: There was 1 failure: 1) Doctrine\Tests\ORM\Functional\QueryTest::testToIterableWithMixedResultArbitraryJoinsScalars Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'Doctrine 2' +'lala 2' /home/runner/work/orm/orm/tests/Tests/ORM/Functional/QueryTest.php:481 Spotted in https://github.com/doctrine/orm/actions/runs/18431080849/job/52518538835?pr=12221
admin added the pull-request label 2026-01-22 16:17:42 +01:00
admin closed this issue 2026-01-22 16:17:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#13595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?