mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
[PR #12093] Disable subquery collection-based ordering for SQL Server #13470
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/doctrine/orm/pull/12093
State: open
Merged: No
This is my fix for issue #8580 where Microsoft SQL Server throws an exception if you include an ORDER BY clause in a subquery. In my case, I found this bug when using a Paginator and running the count command.
I attempted to devise unit testing methods, but couldn't find a reasonable approach. The countQuery function in the paginator is private and cannot be tested directly. SQL Server itself creates the exception, not Doctrine. Since there is no SQL server to spin up for testing that I can find, reproduction or testing is difficult!
I am running this fix on my servers and have encountered no problems, and it does resolve the issue. I am also willing to learn more if anyone can provide constructive guidance or criticism of my attempt.