[PR #11979] #11977 configurable batching support to BasicEntityPersister insert operations #13379

New Issue

admin · 2026-01-22T16:16:57+01:00

admin commented

2026-01-22 16:16:57 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/11979

State: closed
Merged: No

Based of #11978
Implements #11977

This change is mostly exploratory: it highlights some flaws in the API design of
BasicEntityPersister, showing that we need to extract the getInsertSQL() logic
to a new method that produces separate strings for fields and VALUES.

We should then be able to perform simplistic batching whenever $isPostInsertId is not
necessary.

**Original Pull Request:** https://github.com/doctrine/orm/pull/11979 **State:** closed **Merged:** No --- Based of #11978 Implements #11977 This change is mostly exploratory: it highlights some flaws in the API design of `BasicEntityPersister`, showing that we need to extract the `getInsertSQL()` logic to a new method that produces separate strings for fields and `VALUES`. We should then be able to perform simplistic batching whenever `$isPostInsertId` is not necessary.

admin added the pull-request label 2026-01-22 16:16:57 +01:00

admin closed this issue

2026-01-22 16:16:58 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#13379

[PR #11979] #11977 configurable batching support to BasicEntityPersister insert operations #13379

[PR #11979] #11977 configurable batching support to `BasicEntityPersister` insert operations #13379