doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #11546] fix: Quote custom types correctly in SQLFilter #13092

New Issue
Closed
opened 2026-01-22 16:16:09 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:16:09 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/11546

State: closed
Merged: No

This enables the connection to quote the parameters correctly according to the type definition.

My scenario:

  • Symfony 7.1 app
  • doctrine/dbal:3.8.2
  • doctrine/orm:3.2.1, currently updating from doctrine/orm:2.19.5
  • I am using the UlidType from the doctrine bridge (using symfony/ulid underneath) as primary key to the Organization entity

My problem:

I'm using a SQLFilter to permanently set the ulid of the organization permanently for users. After updating doctrine/orm, I got an exception that the format of the query parameter wouldn't conform to the expectation of the database.

My solution

On investigation, I found that the SQLFilter doesn't use the column type to quote the value correctly. This change is supposed to ensure that the correct quoting is done

**Original Pull Request:** https://github.com/doctrine/orm/pull/11546 **State:** closed **Merged:** No --- This enables the connection to quote the parameters correctly according to the type definition. ## My scenario: * Symfony 7.1 app * `doctrine/dbal:3.8.2` * `doctrine/orm:3.2.1`, currently updating from `doctrine/orm:2.19.5` * I am using the `UlidType` from the doctrine bridge (using `symfony/ulid` underneath) as primary key to the `Organization` entity ## My problem: I'm using a SQLFilter to permanently set the ulid of the organization permanently for users. After updating `doctrine/orm`, I got an exception that the format of the query parameter wouldn't conform to the expectation of the database. ## My solution On investigation, I found that the SQLFilter doesn't use the column type to quote the value correctly. This change is supposed to ensure that the correct quoting is done
admin added the pull-request label 2026-01-22 16:16:09 +01:00
admin closed this issue 2026-01-22 16:16:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#13092
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?