[PR #11130] Allow to skip property type validation #12810

Closed
opened 2026-01-22 16:15:14 +01:00 by admin · 0 comments
Owner

Original Pull Request: https://github.com/doctrine/orm/pull/11130

State: closed
Merged: Yes


See https://github.com/doctrine/orm/issues/11073#issuecomment-1822705925 for context.

#10946 introduced validation of property types for the ValidateSchemaCommand. For existing projects, this new feature might uncover quite a few valid problems, that need a little time to fix. This is problematic because if schema validation is run in CI, a project basically can't upgrade until all of the newly discovered errors have been fixed. This leaves two options:

  • Disable schema validation completely and upgrade to 2.17.
  • Stay on 2.16 until all error have been resolved.

Both strategies are not desirable which is why I propose to add a flag to the command that allows us to opt out of the validation of property types. This allows this kind of projects to upgrade to 2.17 and fix the type mismatches iteratively.

**Original Pull Request:** https://github.com/doctrine/orm/pull/11130 **State:** closed **Merged:** Yes --- See https://github.com/doctrine/orm/issues/11073#issuecomment-1822705925 for context. #10946 introduced validation of property types for the `ValidateSchemaCommand`. For existing projects, this new feature might uncover quite a few valid problems, that need a little time to fix. This is problematic because if schema validation is run in CI, a project basically can't upgrade until all of the newly discovered errors have been fixed. This leaves two options: * Disable schema validation completely and upgrade to 2.17. * Stay on 2.16 until all error have been resolved. Both strategies are not desirable which is why I propose to add a flag to the command that allows us to opt out of the validation of property types. This allows this kind of projects to upgrade to 2.17 and fix the type mismatches iteratively.
admin added the pull-request label 2026-01-22 16:15:14 +01:00
admin closed this issue 2026-01-22 16:15:15 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12810