[PR #11015] Make phpdoc accurate #12765

New Issue

admin · 2026-01-22T16:15:05+01:00

admin commented

2026-01-22 16:15:05 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/11015

State: closed
Merged: Yes

When transforming these phpdoc types into native types, things break down. They are correct according to the EBNF, but in practice, there are so-called phase 2 optimizations that allow using ConditionalPrimary, ConditionalFactor and ConditionalTerm instances in places where ConditionalExpression is used.

Here is the relevant piece of code: 42af7cabb7/lib/Doctrine/ORM/Query/SqlWalker.php (L2057-L2104)

Once this PR is merged up, we should be able to use phpcbf to convert phpdoc to native types on 3.0.x without that causing any problem.

**Original Pull Request:** https://github.com/doctrine/orm/pull/11015 **State:** closed **Merged:** Yes --- When transforming these phpdoc types into native types, things break down. They are correct according to the EBNF, but in practice, there are so-called phase 2 optimizations that allow using `ConditionalPrimary`, `ConditionalFactor` and `ConditionalTerm` instances in places where `ConditionalExpression` is used. Here is the relevant piece of code: https://github.com/doctrine/orm/blob/42af7cabb7496d77104132f9d164f9c74da6a629/lib/Doctrine/ORM/Query/SqlWalker.php#L2057-L2104 Once this PR is merged up, we should be able to use phpcbf to convert phpdoc to native types on 3.0.x without that causing any problem.

admin added the pull-request label 2026-01-22 16:15:05 +01:00

admin closed this issue

2026-01-22 16:15:06 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12765